[flang] Add install target to install flang headers #78151
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if there should be a single overall target covering flang-new, the runtime libraries, and the headers. But I am unsure what should call it. Just |
DavidTruby
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Do we need a target to only install the driver? I think we should match clang and install everything relevant under install-flang. In that case install-flang-new could be renamed to install-flang-driver in case anyone wants only the driver.
Regardless, that's somewhat a separate conversation. This change looks good to me!
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
This makes it more convenient to install flang without using the general `ninja install` to install everything. To install flang-new and associated things one needs `ninja install-flang-new install-flang-libraries install-flang-headers`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more convenient to install flang without using the general
ninja installto install everything.To install flang-new and associated things one needs
ninja install-flang-new install-flang-libraries install-flang-headers.