Skip to content

[AArch64] Use parseArchExtension function. NFC #78158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions clang/lib/Basic/Targets/AArch64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,8 @@ AArch64TargetInfo::getVScaleRange(const LangOptions &LangOpts) const {
unsigned AArch64TargetInfo::multiVersionSortPriority(StringRef Name) const {
if (Name == "default")
return 0;
for (const auto &E : llvm::AArch64::Extensions)
if (Name == E.Name)
return E.FmvPriority;
if (auto Ext = llvm::AArch64::parseArchExtension(Name))
return Ext->FmvPriority;
return 0;
}

Expand All @@ -634,24 +633,19 @@ unsigned AArch64TargetInfo::multiVersionFeatureCost() const {
}

bool AArch64TargetInfo::doesFeatureAffectCodeGen(StringRef Name) const {
auto F = llvm::find_if(llvm::AArch64::Extensions, [&](const auto &E) {
return Name == E.Name && !E.DependentFeatures.empty();
});
return F != std::end(llvm::AArch64::Extensions);
if (auto Ext = llvm::AArch64::parseArchExtension(Name))
return !Ext->DependentFeatures.empty();
return false;
}

StringRef AArch64TargetInfo::getFeatureDependencies(StringRef Name) const {
auto F = llvm::find_if(llvm::AArch64::Extensions,
[&](const auto &E) { return Name == E.Name; });
return F != std::end(llvm::AArch64::Extensions) ? F->DependentFeatures
: StringRef();
if (auto Ext = llvm::AArch64::parseArchExtension(Name))
return Ext->DependentFeatures;
return StringRef();
}

bool AArch64TargetInfo::validateCpuSupports(StringRef FeatureStr) const {
for (const auto &E : llvm::AArch64::Extensions)
if (FeatureStr == E.Name)
return true;
return false;
return llvm::AArch64::parseArchExtension(FeatureStr).has_value();
}

bool AArch64TargetInfo::hasFeature(StringRef Feature) const {
Expand Down
22 changes: 8 additions & 14 deletions llvm/lib/TargetParser/AArch64TargetParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,8 @@ std::optional<AArch64::ArchInfo> AArch64::ArchInfo::findBySubArch(StringRef SubA
uint64_t AArch64::getCpuSupportsMask(ArrayRef<StringRef> FeatureStrs) {
uint64_t FeaturesMask = 0;
for (const StringRef &FeatureStr : FeatureStrs) {
for (const auto &E : llvm::AArch64::Extensions)
if (FeatureStr == E.Name) {
FeaturesMask |= (1ULL << E.CPUFeature);
break;
}
if (auto Ext = parseArchExtension(FeatureStr))
FeaturesMask |= (1ULL << Ext->CPUFeature);
}
return FeaturesMask;
}
Expand All @@ -75,17 +72,14 @@ StringRef AArch64::resolveCPUAlias(StringRef Name) {
}

StringRef AArch64::getArchExtFeature(StringRef ArchExt) {
if (ArchExt.starts_with("no")) {
StringRef ArchExtBase(ArchExt.substr(2));
for (const auto &AE : Extensions) {
if (!AE.NegFeature.empty() && ArchExtBase == AE.Name)
return AE.NegFeature;
}
bool IsNegated = ArchExt.starts_with("no");
StringRef ArchExtBase = IsNegated ? ArchExt.drop_front(2) : ArchExt;

if (auto AE = parseArchExtension(ArchExtBase)) {
// Note: the returned string can be empty.
return IsNegated ? AE->NegFeature : AE->Feature;
}

for (const auto &AE : Extensions)
if (!AE.Feature.empty() && ArchExt == AE.Name)
return AE.Feature;
return StringRef();
}

Expand Down