Skip to content

Add the Linux "you can use this binary" bits to run_to_source_breakpoint #78377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jimingham
Copy link
Collaborator

Follow-on to a4cd99e - I forgot you have to add ANY shared library you want to use to extra_images...

…int.

Follow-on to a4cd99e - I forgot you have to
add ANY shared library you want to use to extra_images...
@llvmbot llvmbot added the lldb label Jan 17, 2024
@jimingham jimingham merged commit 705c5b8 into llvm:main Jan 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 17, 2024

@llvm/pr-subscribers-lldb

Author: None (jimingham)

Changes

Follow-on to a4cd99e - I forgot you have to add ANY shared library you want to use to extra_images...


Full diff: https://github.com/llvm/llvm-project/pull/78377.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/executable_first/TestExecutableFirst.py (+2-1)
diff --git a/lldb/test/API/functionalities/executable_first/TestExecutableFirst.py b/lldb/test/API/functionalities/executable_first/TestExecutableFirst.py
index 5c5573d5b38382..957628f695c128 100644
--- a/lldb/test/API/functionalities/executable_first/TestExecutableFirst.py
+++ b/lldb/test/API/functionalities/executable_first/TestExecutableFirst.py
@@ -41,7 +41,8 @@ def test_executable_is_first_before_run(self):
     def test_executable_is_first_during_run(self):
         self.build()
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
-            self, "break after function call", lldb.SBFileSpec("main.cpp")
+            self, "break after function call", lldb.SBFileSpec("main.cpp"),
+            extra_images=["bar"]
         )
 
         first_module = target.GetModuleAtIndex(0)

@jimingham jimingham deleted the fix-shlib-testcase branch January 17, 2024 01:54
Copy link

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r a4cd99ea8736eda2b8b4de34453f55008bcf9c30...970fbad325ac101f930c2eb18a69d3341908b63b lldb/test/API/functionalities/executable_first/TestExecutableFirst.py
View the diff from darker here.
--- TestExecutableFirst.py	2024-01-17 01:50:35.000000 +0000
+++ TestExecutableFirst.py	2024-01-17 01:56:17.298126 +0000
@@ -39,12 +39,14 @@
         )
 
     def test_executable_is_first_during_run(self):
         self.build()
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
-            self, "break after function call", lldb.SBFileSpec("main.cpp"),
-            extra_images=["bar"]
+            self,
+            "break after function call",
+            lldb.SBFileSpec("main.cpp"),
+            extra_images=["bar"],
         )
 
         first_module = target.GetModuleAtIndex(0)
         self.assertTrue(first_module.IsValid(), "We have at least one module")
         executable_module = target.executable

jimingham added a commit to jimingham/from-apple-llvm-project that referenced this pull request Jan 17, 2024
…int (llvm#78377)

Follow-on to a4cd99e - I forgot you
have to add ANY shared library you want to use to extra_images...

(cherry picked from commit 705c5b8)
jimingham added a commit to jimingham/from-apple-llvm-project that referenced this pull request Jan 17, 2024
…int (llvm#78377)

Follow-on to a4cd99e - I forgot you
have to add ANY shared library you want to use to extra_images...

(cherry picked from commit 705c5b8)
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
…int (llvm#78377)

Follow-on to a4cd99e - I forgot you
have to add ANY shared library you want to use to extra_images...
jimingham added a commit to jimingham/from-apple-llvm-project that referenced this pull request Feb 21, 2024
…int (llvm#78377)

Follow-on to a4cd99e - I forgot you
have to add ANY shared library you want to use to extra_images...

(cherry picked from commit 705c5b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants