Skip to content

[libc++] Un-xfail module tests in picolibc tests #78580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[libc++] Un-xfail module tests in picolibc tests #78580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libcxx/test/libcxx/selftest/modules/std-and-std.compat-module.sh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use using-if-exists in ctime.inc, that might be the problem. Otherwise when timespec_get is the only missing part we could ifdef that in ctime.inc if using-if-exists fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a follow up patch #78580

// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 4 additions & 0 deletions libcxx/test/libcxx/selftest/modules/std.compat-module.sh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 4 additions & 0 deletions libcxx/test/std/modules/std.compat.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// A minimal test to validate import works.

// MODULE_DEPENDENCIES: std.compat
Expand Down
1 change: 0 additions & 1 deletion libcxx/utils/libcxx/test/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ def _getAndroidDeviceApi(cfg):
# This is not allowed per C11 7.1.2 Standard headers/6
# Any declaration of a library function shall have external linkage.
when=lambda cfg: "__ANDROID__" in compilerMacros(cfg)
or "__PICOLIBC__" in compilerMacros(cfg)
or platform.system().lower().startswith("aix")
# Avoid building on platforms that don't support modules properly.
or not hasCompileFlag(cfg, "-Wno-reserved-module-identifier"),
Expand Down