[clang-apply-replacements] Deduplicate Implementation of collectReplacementsFromDirectory (NFC)
#78630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unterumarmung
requested review from
fmayer,
bnbarham,
benlangmuir,
PiotrZSL,
kazutakahirata,
HerrCai0907,
AaronBallman and
Endilll
|
I honestly don't know who should review/approve this, but hopefully the change is not complicated. |
…acementsFromDirectory` (NFC) * Convert `collectReplacementsFromDirectory` into a function template. * Employ explicit specialization to maintain implementation in the source file. * Utilize the function template in the source file to eliminate code duplication. * Update the documentation for the function.
unterumarmung
force-pushed
the
clang-apply-replacements-remove-code-dublication
branch
from
cc4591e to
1951bad
Compare
|
The Windows build in the CI is stuck. The change is pretty trivial and doesn't use any features that cannot be found in C++98. So, we can skip the Windows check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectReplacementsFromDirectoryinto a function template.