Skip to content

[libc++] Fix typo in _LIBCPP_REMOVE_TRANSITIVE_INCLUDES #78639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

bobsayshilol
Copy link
Contributor

Spotted by inspection when trialling out _LIBCPP_REMOVE_TRANSITIVE_INCLUDES. No other instances of _LIPCPP_ were found in the repo.

@bobsayshilol bobsayshilol requested a review from a team as a code owner January 18, 2024 22:32
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 18, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 18, 2024

@llvm/pr-subscribers-libcxx

Author: None (bobsayshilol)

Changes

Spotted by inspection when trialling out _LIBCPP_REMOVE_TRANSITIVE_INCLUDES. No other instances of _LIPCPP_ were found in the repo.


Full diff: https://github.com/llvm/llvm-project/pull/78639.diff

2 Files Affected:

  • (modified) libcxx/include/concepts (+1-1)
  • (modified) libcxx/include/sstream (+1-1)
diff --git a/libcxx/include/concepts b/libcxx/include/concepts
index 196fa2e0ea7069..5fdf30ecfbd3fb 100644
--- a/libcxx/include/concepts
+++ b/libcxx/include/concepts
@@ -155,7 +155,7 @@ namespace std {
 #include <__config>
 #include <version>
 
-#if _LIBCPP_STD_VER <= 20 && !defined(_LIPCPP_REMOVE_TRANSITIVE_INCLUDES)
+#if _LIBCPP_STD_VER <= 20 && !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES)
 #  include <type_traits>
 #endif
 
diff --git a/libcxx/include/sstream b/libcxx/include/sstream
index 9f75b7e0ac9e4b..6c354cf0b39737 100644
--- a/libcxx/include/sstream
+++ b/libcxx/include/sstream
@@ -1108,7 +1108,7 @@ _LIBCPP_END_NAMESPACE_STD
 
 _LIBCPP_POP_MACROS
 
-#if _LIBCPP_STD_VER <= 20 && !defined(_LIPCPP_REMOVE_TRANSITIVE_INCLUDES)
+#if _LIBCPP_STD_VER <= 20 && !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES)
 #  include <type_traits>
 #endif
 

@bobsayshilol
Copy link
Contributor Author

The failed job doesn't look relevant to my changes:

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

I don't see an option to retry though. Can anyone with perms give it a poke please?

@mordante
Copy link
Member

The failed job doesn't look relevant to my changes:

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

I don't see an option to retry though. Can anyone with perms give it a poke please?

Thanks for your contribution.

The CI sometimes has hiccups, but it's green. Do you need help merging the commit?

@bobsayshilol
Copy link
Contributor Author

Do you need help merging the commit?

Yes please. I don't have write access so I can't land it myself. Thanks!

@mordante mordante merged commit f73bf45 into llvm:main Jan 21, 2024
@bobsayshilol bobsayshilol deleted the fix_transitive_includes_typo branch January 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants