Skip to content

[libc++] Add "using-if-exists" to timespec_get in modules #78686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[libc++] Add "using-if-exists" to timespec_get in modules #78686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f87e9
[libc++] Add "using-if-exists" to timespec_get in modules
domin144 Jan 19, 2024
7443ba5
Remove XFAIL from remaining tests
domin144 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/modules/std.compat/ctime.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ export {
using ::mktime;
using ::strftime;
using ::time;
using ::timespec_get;
using ::timespec_get _LIBCPP_USING_IF_EXISTS;
} // export
2 changes: 1 addition & 1 deletion libcxx/modules/std/ctime.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ export namespace std {
using std::mktime;
using std::strftime;
using std::time;
using std::timespec_get;
using std::timespec_get _LIBCPP_USING_IF_EXISTS;
} // namespace std
4 changes: 0 additions & 4 deletions libcxx/test/libcxx/selftest/modules/std-and-std.compat-module.sh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 0 additions & 4 deletions libcxx/test/libcxx/selftest/modules/std.compat-module.sh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 0 additions & 4 deletions libcxx/test/std/modules/std.compat.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// A minimal test to validate import works.

// MODULE_DEPENDENCIES: std.compat
Expand Down