Skip to content

[libc] add missing header dependencies for sched objects #78741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Jan 19, 2024

This patch fixes full build problems in #78721 (the header problem).
The libc.a target can be built now.

As a separate issue, check-libc is failing because undefined symbols from libunwind, which I do not actually know the reason yet. I will be looking into it.

@llvmbot llvmbot added the libc label Jan 19, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 19, 2024

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/78741.diff

2 Files Affected:

  • (modified) libc/src/sched/linux/CMakeLists.txt (+8)
  • (modified) libc/src/spawn/linux/CMakeLists.txt (+1)
diff --git a/libc/src/sched/linux/CMakeLists.txt b/libc/src/sched/linux/CMakeLists.txt
index d53c6e5d45052e..ac95bf85da534f 100644
--- a/libc/src/sched/linux/CMakeLists.txt
+++ b/libc/src/sched/linux/CMakeLists.txt
@@ -52,6 +52,8 @@ add_entrypoint_object(
     ../sched_setparam.h
   DEPENDS
     libc.include.sys_syscall
+    libc.include.time
+    libc.include.sched
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )
@@ -64,6 +66,8 @@ add_entrypoint_object(
     ../sched_getparam.h
   DEPENDS
     libc.include.sys_syscall
+    libc.include.time
+    libc.include.sched
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )
@@ -76,6 +80,8 @@ add_entrypoint_object(
     ../sched_setscheduler.h
   DEPENDS
     libc.include.sys_syscall
+    libc.include.time
+    libc.include.sched
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )
@@ -87,6 +93,7 @@ add_entrypoint_object(
   HDRS
     ../sched_getscheduler.h
   DEPENDS
+    libc.include.sched
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
@@ -124,6 +131,7 @@ add_entrypoint_object(
     ../sched_rr_get_interval.h
   DEPENDS
     libc.include.sys_syscall
+    libc.include.sched
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno
 )
diff --git a/libc/src/spawn/linux/CMakeLists.txt b/libc/src/spawn/linux/CMakeLists.txt
index 9bd3ac50415b1f..9ef3a9d18b0c69 100644
--- a/libc/src/spawn/linux/CMakeLists.txt
+++ b/libc/src/spawn/linux/CMakeLists.txt
@@ -8,6 +8,7 @@ add_entrypoint_object(
     libc.include.fcntl
     libc.include.spawn
     libc.include.sys_syscall
+    libc.include.signal
     libc.src.__support.CPP.optional
     libc.src.__support.OSUtil.osutil
     libc.src.spawn.file_actions

@SchrodingerZhu SchrodingerZhu changed the title fix: add missing header dependencies for sched objects [libc] add missing header dependencies for sched objects Jan 19, 2024
@lntue lntue merged commit 128d53f into llvm:main Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants