Skip to content

[lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) #78817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Jan 20, 2024

Starting with macOS 14, the NSTimeZone and CFTimeZone types are backed by swift implementations. These tests won't pass on mainline lldb, since it doesn't have Swift support.

@llvmbot
Copy link
Member

llvmbot commented Jan 20, 2024

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/78817.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py (+16-10)
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
index a1ffe84ad556f0..c56b887a3f5088 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
@@ -19,6 +19,11 @@ def test_nsdate_with_run_command(self):
         """Test formatters for  NSDate."""
         self.appkit_tester_impl(self.nsdate_data_formatter_commands, False)
 
+    @skipIf(macos_version=[">=", "14.0"])
+    def test_timezone_with_run_command(self):
+        """Test formatters for NSTimeZone and CFTimeZone."""
+        self.appkit_tester_impl(self.timezone_data_formatter_commands, False)
+
     def nsdate_data_formatter_commands(self):
         self.expect(
             "frame variable date1 date2",
@@ -51,16 +56,6 @@ def nsdate_data_formatter_commands(self):
         self.expect_expr("date_1970_plus_05", result_summary="1970-01-01 00:00:00 UTC")
         self.expect_expr("date_1970_plus_04", result_summary="1970-01-01 00:00:00 UTC")
 
-        self.expect(
-            "frame variable cupertino home europe",
-            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
-        )
-
-        self.expect(
-            "frame variable cupertino_ns home_ns europe_ns",
-            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
-        )
-
         self.expect(
             "frame variable mut_bv",
             substrs=[
@@ -71,3 +66,14 @@ def nsdate_data_formatter_commands(self):
 
         self.expect_expr("distant_past", result_summary="0001-01-01 00:00:00 UTC")
         self.expect_expr("distant_future", result_summary="4001-01-01 00:00:00 UTC")
+
+    def timezone_data_formatter_commands(self):
+        self.expect(
+            "frame variable cupertino home europe",
+            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
+        )
+
+        self.expect(
+            "frame variable cupertino_ns home_ns europe_ns",
+            substrs=['"America/Los_Angeles"', '"Europe/Rome"', '"Europe/Paris"'],
+        )

@kastiglione kastiglione merged commit b7355ee into llvm:main Jan 21, 2024
@kastiglione kastiglione deleted the lldb-Skip-ObjC-timezone-tests-on-macOS-14-NFC branch January 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants