Skip to content

[clang-repl] We do not need to call new in the object allocation. #78843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[clang-repl] We do not need to call new in the object allocation. #78843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions clang/unittests/Interpreter/InterpreterTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ using namespace clang;
#define CLANG_INTERPRETER_NO_SUPPORT_EXEC
#endif

#if LLVM_ADDRESS_SANITIZER_BUILD || LLVM_HWADDRESS_SANITIZER_BUILD
#include <sanitizer/lsan_interface.h>
#else
extern "C" void __lsan_ignore_object(const void *p) {}
#endif

int Global = 42;
// JIT reports symbol not found on Windows without the visibility attribute.
REPL_EXTERNAL_VISIBILITY int getGlobal() { return Global; }
Expand Down Expand Up @@ -257,7 +251,12 @@ TEST(IncrementalProcessing, FindMangledNameSymbol) {
static Value AllocateObject(TypeDecl *TD, Interpreter &Interp) {
std::string Name = TD->getQualifiedNameAsString();
Value Addr;
cantFail(Interp.ParseAndExecute("new " + Name + "()", &Addr));
// FIXME: Consider providing an option in clang::Value to take ownership of
// the memory created from the interpreter.
// cantFail(Interp.ParseAndExecute("new " + Name + "()", &Addr));

// The lifetime of the temporary is extended by the clang::Value.
cantFail(Interp.ParseAndExecute(Name + "()", &Addr));
return Addr;
}

Expand Down Expand Up @@ -317,8 +316,6 @@ TEST(IncrementalProcessing, InstantiateTemplate) {
auto fn =
cantFail(Interp->getSymbolAddress(MangledName)).toPtr<TemplateSpecFn>();
EXPECT_EQ(42, fn(NewA.getPtr()));
// FIXME: release the memory.
__lsan_ignore_object(NewA.getPtr());
}

#ifdef CLANG_INTERPRETER_NO_SUPPORT_EXEC
Expand Down