Skip to content

[libc++] FreeBSD CI: Adds <signal.h> to check_assertion.h #78863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

H-G-Hristov
Copy link
Contributor

@H-G-Hristov H-G-Hristov commented Jan 20, 2024

...in attempt to fix the FreeBSD CI.

I noticed that suddenly some tests in the latest PRs fail to compile on FreeBSD. This tries to resolved the issue.

@H-G-Hristov H-G-Hristov requested a review from a team as a code owner January 20, 2024 21:20
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 20, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 20, 2024

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

...in attempt to fix the FreeBSD CI


Full diff: https://github.com/llvm/llvm-project/pull/78863.diff

1 Files Affected:

  • (modified) libcxx/test/support/check_assertion.h (+2)
diff --git a/libcxx/test/support/check_assertion.h b/libcxx/test/support/check_assertion.h
index 485f8103c7ad8d..1811df5f474f52 100644
--- a/libcxx/test/support/check_assertion.h
+++ b/libcxx/test/support/check_assertion.h
@@ -24,7 +24,9 @@
 
 #include <unistd.h>
 #include <errno.h>
+#include <signal.h>
 #include <sys/wait.h>
+
 #include "test_macros.h"
 #include "test_allocator.h"
 

@H-G-Hristov H-G-Hristov changed the title [libc++] FreeBSD CI: Adds <signal.h> to check_assertion.h` [libc++] FreeBSD CI: Adds <signal.h> to check_assertion.h Jan 20, 2024
@var-const var-const self-assigned this Jan 20, 2024
@var-const var-const added the hardening Issues related to the hardening effort label Jan 20, 2024
Copy link
Member

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

@var-const var-const merged commit 07b5829 into llvm:main Jan 20, 2024
@H-G-Hristov H-G-Hristov deleted the hgh/libcxx/FreeBSD-try-to-fix-CI branch January 21, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardening Issues related to the hardening effort libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants