Skip to content

[libc] Add missing header ioctl.h on aarch64. #78865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2024
Merged

[libc] Add missing header ioctl.h on aarch64. #78865

merged 1 commit into from
Jan 20, 2024

Conversation

lntue
Copy link
Contributor

@lntue lntue commented Jan 20, 2024

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jan 20, 2024

@llvm/pr-subscribers-libc

Author: None (lntue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/78865.diff

2 Files Affected:

  • (modified) libc/config/linux/aarch64/headers.txt (+2)
  • (modified) libc/src/unistd/linux/CMakeLists.txt (+1)
diff --git a/libc/config/linux/aarch64/headers.txt b/libc/config/linux/aarch64/headers.txt
index 6a4a4aaeb0a8d4..709a8dbdedc98f 100644
--- a/libc/config/linux/aarch64/headers.txt
+++ b/libc/config/linux/aarch64/headers.txt
@@ -21,4 +21,6 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.threads
     libc.include.time
     libc.include.unistd
+
+    libc.include.sys_ioctl
 )
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index 2507e1e9a9387a..ab9eca19e65083 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -226,6 +226,7 @@ add_entrypoint_object(
     ../isatty.h
   DEPENDS
     libc.include.unistd
+    libc.include.sys_ioctl
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil
     libc.src.errno.errno

@@ -21,4 +21,6 @@ set(TARGET_PUBLIC_HEADERS
libc.include.threads
libc.include.time
libc.include.unistd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just follow the pattern from libc/config/linux/x86_64/headers.txt

@lntue lntue merged commit 975deb3 into llvm:main Jan 20, 2024
@lntue lntue deleted the ioctl branch January 20, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants