Skip to content

[llvm-objcopy] Don't remove .gnu_debuglink section when using --strip-all #78919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[llvm-objcopy] Don't remove .gnu_debuglink section when using --strip-all #78919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0a603c
Make llvm-strip not eat the .gnu_debuglink section
felixkellenbenz Jan 21, 2024
eb76f51
Add test that checks if llvm-strip removes the .gnu_debuglink section
felixkellenbenz Jan 22, 2024
4311d05
Add test to check that llvm-strip does not remove the .gnu_debuglink
felixkellenbenz Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,8 @@ static Error replaceAndRemoveSections(const CommonConfig &Config,
return false;
if (StringRef(Sec.Name).starts_with(".gnu.warning"))
return false;
if (StringRef(Sec.Name).starts_with(".gnu_debuglink"))
return false;
// We keep the .ARM.attribute section to maintain compatibility
// with Debian derived distributions. This is a bug in their
// patchset as documented here:
Expand Down
5 changes: 4 additions & 1 deletion llvm/test/tools/llvm-objcopy/ELF/strip-all.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,19 @@ Sections:
Flags: [ ]
- Name: .gnu.warning.foo
Type: SHT_PROGBITS
- Name: .gnu_debuglink
Type: SHT_PROGBITS
ProgramHeaders:
# Use an arbitrary segment type to show that the segment type is unimportant.
- Type: 0x61234567
FirstSec: non_alloc_in_segment
LastSec: non_alloc_in_segment

# CHECK: SectionHeaderCount: 6
# CHECK: SectionHeaderCount: 7

# CHECK: Name: non_alloc_in_segment
# CHECK: Name: .bss
# CHECK: Name: .text
# CHECK: Name: .gnu.warning.foo
# CHECK: Name: .gnu_debuglink
# CHECK: Name: .shstrtab