Skip to content

[Support] Refactor getN1Bits so it does not work around any g++ bug #78933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions llvm/include/llvm/Support/Discriminator.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,9 @@ static inline unsigned getBaseFSBitEnd() {
}

// Set bits in range of [0 .. n] to 1. Used in FS Discriminators.
static inline unsigned getN1Bits(int N) {
// Work around the g++ bug that folding "(1U << (N + 1)) - 1" to 0.
if (N == 31)
return 0xFFFFFFFF;
static inline unsigned getN1Bits(unsigned N) {
assert((N < 32) && "N is invalid");
return (1U << (N + 1)) - 1;
return 0xFFFFFFFF >> (31 - N);
}

} // namespace llvm
Expand Down