Skip to content

[flang] Handle -S assemble only flag in flang-to-external-fc #78979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

DavidSpickett
Copy link
Collaborator

Flang was recently updated on Compiler Explorer and by default it's in assemble only mode, you have to enable linking and executing.

This means that the default output for flang-to-external-fc is nothing, as it doesn't know what -S means. You'd have to know to enable the link to binary option to see any output.

Handle -S so that users of Compiler Explorer don't have to wonder why the "compiler" is broken.

Flang was recently updated on Compiler Explorer and by default
it's in assemble only mode, you have to enable linking and executing.

This means that the default output for flang-to-external-fc is
nothing, as it doesn't know what `-S` means. You'd have to know
to enable the link to binary option to see any output.

Handle `-S` so that users of Compiler Explorer don't have to wonder
why the "compiler" is broken.
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Jan 22, 2024
Copy link
Contributor

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DavidSpickett DavidSpickett merged commit e302950 into llvm:main Jan 22, 2024
@DavidSpickett DavidSpickett deleted the flang-ext-fc branch January 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants