Skip to content

[HEXAGON] Inlining Division #79021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

quic-asaravan
Copy link
Contributor

This patch inlines float division function calls for hexagon.

Awanish Pandey and others added 2 commits January 22, 2024 09:15
This patch inlines float division function calls for hexagon.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@quic-asaravan quic-asaravan marked this pull request as ready for review January 23, 2024 02:36
@quic-asaravan
Copy link
Contributor Author

@SundeepKushwaha Can you review ?

@iajbar
Copy link
Contributor

iajbar commented Jan 23, 2024

It looks good to me. Thanks Abinaya!

Copy link
Contributor

@iajbar iajbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@SundeepKushwaha SundeepKushwaha merged commit dc5b4da into llvm:main Jan 24, 2024
@androm3da
Copy link
Member

@iajbar does it make sense to cherry pick this change onto the llvmorg-18.1.0 release branch? Does this fix bugs or just improve codegen?

@quic-asaravan
Copy link
Contributor Author

@androm3da The patch is a codegen improvement and doesn't fix any bugs.

@quic-asaravan quic-asaravan deleted the Hexagon-Div-Inlining branch March 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants