[clang-repl] Typo within InterpreterTest.cpp #79119
Conversation
Recent changes to InterpreterTest.cpp introduced typos within code passed to a Parse() function. This causes some tests to fail, namely IncrementalProcessing.InstantiateTemplate. Change-Id: I79a09030f980b1bc766e27cc6acb944fbc2422ac
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-clang Author: Nashe Mncube (nasherm) ChangesRecent changes to InterpreterTest.cpp (#76218) introduced typos within code passed to a Parse() function. This causes some tests to fail, namely IncrementalProcessing.InstantiateTemplate. Full diff: https://github.com/llvm/llvm-project/pull/79119.diff 1 Files Affected:
diff --git a/clang/unittests/Interpreter/InterpreterTest.cpp b/clang/unittests/Interpreter/InterpreterTest.cpp
index e76c0677db5ead1..6d2e5c79bc242ce 100644
--- a/clang/unittests/Interpreter/InterpreterTest.cpp
+++ b/clang/unittests/Interpreter/InterpreterTest.cpp
@@ -256,7 +256,8 @@ static Value AllocateObject(TypeDecl *TD, Interpreter &Interp) {
// cantFail(Interp.ParseAndExecute("new " + Name + "()", &Addr));
// The lifetime of the temporary is extended by the clang::Value.
- cantFail(Interp.ParseAndExecute(Name + "()", &Addr));
+ cantFail(Interp.ParseAndExecute(Name + "();", &Addr));
+ Addr.setKind(Value::Kind::K_PtrOrObj);
return Addr;
}
|
| @@ -256,7 +256,8 @@ static Value AllocateObject(TypeDecl *TD, Interpreter &Interp) { | |||
| // cantFail(Interp.ParseAndExecute("new " + Name + "()", &Addr)); | |||
|
|
|||
| // The lifetime of the temporary is extended by the clang::Value. | |||
| cantFail(Interp.ParseAndExecute(Name + "()", &Addr)); | |||
| cantFail(Interp.ParseAndExecute(Name + "();", &Addr)); | |||
| Addr.setKind(Value::Kind::K_PtrOrObj); | |||
There was a problem hiding this comment.
Could you explain why we need this? The missing semicolon on the previous line is on purpose. This tells the interpreter to store its result into the Value object.
|
Need to follow proper contribution process. So closing for now |
Recent changes to InterpreterTest.cpp (#76218) introduced typos within code passed to a Parse() function. This causes some tests to fail, namely IncrementalProcessing.InstantiateTemplate.