Skip to content

[libc] Fix implicit conversions in FEnvImpl for arm32. #79147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lntue
Copy link
Contributor

@lntue lntue commented Jan 23, 2024

No description provided.

@lntue lntue requested review from gchatelet and jhuber6 January 23, 2024 14:59
@llvmbot llvmbot added the libc label Jan 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2024

@llvm/pr-subscribers-libc

Author: None (lntue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/79147.diff

1 Files Affected:

  • (modified) libc/src/__support/FPUtil/arm/FEnvImpl.h (+2-2)
diff --git a/libc/src/__support/FPUtil/arm/FEnvImpl.h b/libc/src/__support/FPUtil/arm/FEnvImpl.h
index 1a89de50b6b6048..ac4673cf20f6323 100644
--- a/libc/src/__support/FPUtil/arm/FEnvImpl.h
+++ b/libc/src/__support/FPUtil/arm/FEnvImpl.h
@@ -135,8 +135,8 @@ LIBC_INLINE int set_except(int excepts) {
 LIBC_INLINE int raise_except(int excepts) {
   float zero = 0.0f;
   float one = 1.0f;
-  float large_value = FPBits<float>::max_normal();
-  float small_value = FPBits<float>::min_normal();
+  float large_value = FPBits<float>::max_normal().get_val();
+  float small_value = FPBits<float>::min_normal().get_val();
   auto divfunc = [](float a, float b) {
     __asm__ __volatile__("flds  s0, %0\n\t"
                          "flds  s1, %1\n\t"

@lntue lntue requested a review from SchrodingerZhu January 23, 2024 15:18
@lntue lntue changed the title [libc] Fix explicit conversion in FEnvImpl for arm32. [libc] Fix implicit conversions in FEnvImpl for arm32. Jan 23, 2024
@gchatelet
Copy link
Contributor

Ha sorry I missed your patch @lntue, I've already fixed it in #79151.
My apologies for that 🙇

@SchrodingerZhu
Copy link
Contributor

@lntue close this?

@lntue lntue closed this Jan 23, 2024
@lntue
Copy link
Contributor Author

lntue commented Jan 23, 2024

Already fixed in #79151 .

@lntue lntue deleted the arm branch January 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants