Skip to content

Revert "[libc] Fix forward arm32 buildbot" #79201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

frobtech
Copy link
Contributor

Reverts #79151, necessary to revert #79128, which broke all production builds and landed without review.

@llvmbot llvmbot added the libc label Jan 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2024

@llvm/pr-subscribers-libc

Author: Roland McGrath (frobtech)

Changes

Reverts llvm/llvm-project#79151, necessary to revert #79128, which broke all production builds and landed without review.


Full diff: https://github.com/llvm/llvm-project/pull/79201.diff

1 Files Affected:

  • (modified) libc/src/__support/FPUtil/arm/FEnvImpl.h (+2-2)
diff --git a/libc/src/__support/FPUtil/arm/FEnvImpl.h b/libc/src/__support/FPUtil/arm/FEnvImpl.h
index ac4673cf20f6323..1a89de50b6b6048 100644
--- a/libc/src/__support/FPUtil/arm/FEnvImpl.h
+++ b/libc/src/__support/FPUtil/arm/FEnvImpl.h
@@ -135,8 +135,8 @@ LIBC_INLINE int set_except(int excepts) {
 LIBC_INLINE int raise_except(int excepts) {
   float zero = 0.0f;
   float one = 1.0f;
-  float large_value = FPBits<float>::max_normal().get_val();
-  float small_value = FPBits<float>::min_normal().get_val();
+  float large_value = FPBits<float>::max_normal();
+  float small_value = FPBits<float>::min_normal();
   auto divfunc = [](float a, float b) {
     __asm__ __volatile__("flds  s0, %0\n\t"
                          "flds  s1, %1\n\t"

@frobtech frobtech merged commit 9122d19 into main Jan 23, 2024
@frobtech frobtech deleted the revert-79151-fix_forward_arm32_buildbot branch January 23, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants