Skip to content

[lldb][NFCI] Remove unused method BreakpointIDList::FindBreakpointID(const char *, size_t *) #79215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

bulbazord
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2024

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/79215.diff

2 Files Affected:

  • (modified) lldb/include/lldb/Breakpoint/BreakpointIDList.h (-2)
  • (modified) lldb/source/Breakpoint/BreakpointIDList.cpp (-9)
diff --git a/lldb/include/lldb/Breakpoint/BreakpointIDList.h b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
index 6c57d9bc507952f..ddf85dd78cf2e0c 100644
--- a/lldb/include/lldb/Breakpoint/BreakpointIDList.h
+++ b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
@@ -45,8 +45,6 @@ class BreakpointIDList {
   // TODO: This should take a const BreakpointID.
   bool FindBreakpointID(BreakpointID &bp_id, size_t *position) const;
 
-  bool FindBreakpointID(const char *bp_id, size_t *position) const;
-
   // Returns a pair consisting of the beginning and end of a breakpoint
   // ID range expression.  If the input string is not a valid specification,
   // returns an empty pair.
diff --git a/lldb/source/Breakpoint/BreakpointIDList.cpp b/lldb/source/Breakpoint/BreakpointIDList.cpp
index 5ab2c9a8dc3865b..5904647314bc0c7 100644
--- a/lldb/source/Breakpoint/BreakpointIDList.cpp
+++ b/lldb/source/Breakpoint/BreakpointIDList.cpp
@@ -62,15 +62,6 @@ bool BreakpointIDList::FindBreakpointID(BreakpointID &bp_id,
   return false;
 }
 
-bool BreakpointIDList::FindBreakpointID(const char *bp_id_str,
-                                        size_t *position) const {
-  auto bp_id = BreakpointID::ParseCanonicalReference(bp_id_str);
-  if (!bp_id)
-    return false;
-
-  return FindBreakpointID(*bp_id, position);
-}
-
 //  This function takes OLD_ARGS, which is usually the result of breaking the
 //  command string arguments into
 //  an array of space-separated strings, and searches through the arguments for

@jimingham
Copy link
Collaborator

LGTM

@bulbazord bulbazord merged commit 59a6525 into llvm:main Jan 25, 2024
@bulbazord bulbazord deleted the unused-find-bkpt-id branch January 25, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants