Add necessary permissions to release issue workflow #79272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/cherry-pick` command needs `issues: write` to post a comment on the issue. The `/branch` command also posts a comment, and also needs `pull-requests: write` to open a PR.
|
@llvm/pr-subscribers-github-workflow Author: Nikita Popov (nikic) ChangesThe This should fix the failure encountered at #79253 (comment). Full diff: https://github.com/llvm/llvm-project/pull/79272.diff 1 Files Affected:
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index 1f45799af169547..3c089c5465472fc 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -33,6 +33,8 @@ jobs:
backport-commits:
name: Backport Commits
runs-on: ubuntu-latest
+ permissions:
+ issues: write
if: >-
(github.repository == 'llvm/llvm-project') &&
!startswith(github.event.comment.body, '<!--IGNORE-->') &&
@@ -66,6 +68,9 @@ jobs:
create-pull-request:
name: Create Pull Request
runs-on: ubuntu-latest
+ permissions:
+ issues: write
+ pull-requests: write
if: >-
(github.repository == 'llvm/llvm-project') &&
!startswith(github.event.comment.body, '<!--IGNORE-->') &&
|
tstellar
approved these changes
Jan 24, 2024
|
Unfortunately we still get a permission error. I think this is because we're using the wrong token to post the issue comment. I've opened #79300 to pass two separate tokens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/cherry-pickcommand needsissues: writeto post a comment on the issue. The/branchcommand also posts a comment, and also needspull-requests: writeto open a PR.This should fix the failure encountered at #79253 (comment).