[MemProf] Add missing header to list of installed headers. #79413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were buildbot failures when running memprof tests: ******************** Failed Tests (12): MemProfiler-x86_64-linux :: TestCases/interface_test.cpp MemProfiler-x86_64-linux :: TestCases/log_path_test.cpp MemProfiler-x86_64-linux :: TestCases/memprof_merge_mib.cpp MemProfiler-x86_64-linux :: TestCases/memprof_profile_dump.cpp MemProfiler-x86_64-linux :: TestCases/profile_reset.cpp MemProfiler-x86_64-linux :: TestCases/unaligned_loads_and_stores.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/interface_test.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/log_path_test.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/memprof_merge_mib.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/memprof_profile_dump.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/profile_reset.cpp MemProfiler-x86_64-linux-dynamic :: TestCases/unaligned_loads_and_stores.cpp See - https://lab.llvm.org/buildbot/#/builders/258/builds/8852 - https://lab.llvm.org/buildbot/#/builders/258/builds/12876 I suspect the failure is because when build with -DLLVM_ENABLE_RUNTIMES=compiler-rt -DCOMPILER_RT_BUILD_SANITIZERS=OFF, the headers sanitizer/allocator_interface.h and sanitizer/common_interface_defs.h are not be copied to the build tree, and not installed. But in the failed memprof tests, sanitizer/allocator_interface.h or sanitizer/memprof_interface.h is included. This patch adds sanitizer/allocator_interface.h and sanitizer/memprof_interface.h to memprof headers if COMPILER_RT_BUILD_SANITIZERS is false.
Enna1
requested review from
petrhosek,
MaskRay,
vitalybuka,
AaronBallman and
teresajohnson
|
I found https://reviews.llvm.org/D90190, it seems that why we decouple COMPILER_RT_BUILD_MEMPROF from COMPILER_RT_BUILD_SANITIZERS. |
|
cc @AaronBallman reported this buildbot failure in #69625 |
teresajohnson
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were buildbot failures when running memprof tests:
Failed Tests (12):
MemProfiler-x86_64-linux :: TestCases/interface_test.cpp
MemProfiler-x86_64-linux :: TestCases/log_path_test.cpp
MemProfiler-x86_64-linux :: TestCases/memprof_merge_mib.cpp
MemProfiler-x86_64-linux :: TestCases/memprof_profile_dump.cpp
MemProfiler-x86_64-linux :: TestCases/profile_reset.cpp
MemProfiler-x86_64-linux :: TestCases/unaligned_loads_and_stores.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/interface_test.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/log_path_test.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/memprof_merge_mib.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/memprof_profile_dump.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/profile_reset.cpp
MemProfiler-x86_64-linux-dynamic :: TestCases/unaligned_loads_and_stores.cpp
See
I suspect the failure is because when build with
-DLLVM_ENABLE_RUNTIMES=compiler-rt -DCOMPILER_RT_BUILD_SANITIZERS=OFF,
the headers sanitizer/allocator_interface.h and sanitizer/common_interface_defs.h
are not copied to the build tree, and not installed.
But in the failed memprof tests,
sanitizer/allocator_interface.h or sanitizer/memprof_interface.h is included.
This patch adds sanitizer/allocator_interface.h and sanitizer/memprof_interface.h to memprof headers if COMPILER_RT_BUILD_SANITIZERS is false.