[mlir][bufferization][WIP] Use BufferOriginAnalysis to fold away dealloc runtime checks
#79602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `BufferViewFlowOpInterface` to the bufferization dialect. This interface can be implemented by ops that operate on buffers to indicate that a buffer op result and/or region entry block argument may be the same buffer as a buffer operand (or a view thereof). This interface is queried by the `BufferViewFlowAnalysis`. There are currently no ops that implement this interface. The first op implementations will be added in a consecutive commit. BEGIN_PUBLIC No public commit message needed for presubmit. END_PUBLIC
|
Re-uploaded to LLVM github repo as #86461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
BufferOriginAnalysis, which can be queried by the buffer deallocation pass to check if two buffers originate from the same allocation.This analysis enables additional simplifications during
-buffer-deallocation-simplification. In particular, "regular"scf.forloop nests, that yield buffers (or reallocations thereof) in the same order as they appear in theiter_args, are now handled much more efficiently. (TODO: Add test case.) Such IR patterns are generated by the sparse compiler.Depends on #78718. Review only the top commit.