Skip to content

[clang][Interp] Emit const references for Float arguments #79753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[clang][Interp] Emit const references for Float arguments #79753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clang/lib/AST/Interp/Opcodes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def FnPtr : Type;
// Types transferred to the interpreter.
//===----------------------------------------------------------------------===//

class ArgType { string Name = ?; }
class ArgType { string Name = ?; bit AsRef = false; }
def ArgSint8 : ArgType { let Name = "int8_t"; }
def ArgUint8 : ArgType { let Name = "uint8_t"; }
def ArgSint16 : ArgType { let Name = "int16_t"; }
Expand All @@ -44,9 +44,9 @@ def ArgSint32 : ArgType { let Name = "int32_t"; }
def ArgUint32 : ArgType { let Name = "uint32_t"; }
def ArgSint64 : ArgType { let Name = "int64_t"; }
def ArgUint64 : ArgType { let Name = "uint64_t"; }
def ArgFloat : ArgType { let Name = "Floating"; }
def ArgIntAP : ArgType { let Name = "IntegralAP<false>"; }
def ArgIntAPS : ArgType { let Name = "IntegralAP<true>"; }
def ArgIntAP : ArgType { let Name = "IntegralAP<false>"; let AsRef = true; }
def ArgIntAPS : ArgType { let Name = "IntegralAP<true>"; let AsRef = true; }
def ArgFloat : ArgType { let Name = "Floating"; let AsRef = true; }
def ArgBool : ArgType { let Name = "bool"; }

def ArgFunction : ArgType { let Name = "const Function *"; }
Expand Down
50 changes: 40 additions & 10 deletions clang/utils/TableGen/ClangOpcodesEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,15 @@ void ClangOpcodesEmitter::EmitInterp(raw_ostream &OS, StringRef N,

// Emit calls to read arguments.
for (size_t I = 0, N = Args.size(); I < N; ++I) {
OS << " auto V" << I;
const auto *Arg = Args[I];
bool AsRef = Arg->getValueAsBit("AsRef");

if (AsRef)
OS << " const auto &V" << I;
else
OS << " const auto V" << I;
OS << " = ";
OS << "ReadArg<" << Args[I]->getValueAsString("Name")
OS << "ReadArg<" << Arg->getValueAsString("Name")
<< ">(S, PC);\n";
}

Expand Down Expand Up @@ -192,8 +198,14 @@ void ClangOpcodesEmitter::EmitEmitter(raw_ostream &OS, StringRef N,

// Emit the list of arguments.
OS << "bool ByteCodeEmitter::emit" << ID << "(";
for (size_t I = 0, N = Args.size(); I < N; ++I)
OS << Args[I]->getValueAsString("Name") << " A" << I << ", ";
for (size_t I = 0, N = Args.size(); I < N; ++I) {
const auto *Arg = Args[I];
bool AsRef = Arg->getValueAsBit("AsRef");
auto Name = Arg->getValueAsString("Name");

OS << (AsRef ? "const " : " ") << Name << " " << (AsRef ? "&" : "") << "A"
<< I << ", ";
}
OS << "const SourceInfo &L) {\n";

// Emit a call to write the opcodes.
Expand All @@ -218,8 +230,14 @@ void ClangOpcodesEmitter::EmitProto(raw_ostream &OS, StringRef N,
auto Args = R->getValueAsListOfDefs("Args");
Enumerate(R, N, [&OS, &Args](ArrayRef<const Record *> TS, const Twine &ID) {
OS << "bool emit" << ID << "(";
for (auto *Arg : Args)
OS << Arg->getValueAsString("Name") << ", ";
for (size_t I = 0, N = Args.size(); I < N; ++I) {
const auto *Arg = Args[I];
bool AsRef = Arg->getValueAsBit("AsRef");
auto Name = Arg->getValueAsString("Name");

OS << (AsRef ? "const " : " ") << Name << " " << (AsRef ? "&" : "")
<< ", ";
}
OS << "const SourceInfo &);\n";
});

Expand Down Expand Up @@ -275,8 +293,14 @@ void ClangOpcodesEmitter::EmitGroup(raw_ostream &OS, StringRef N,
OS << "::" << EmitFuncName << "(";
for (size_t I = 0, N = Types->size(); I < N; ++I)
OS << "PrimType T" << I << ", ";
for (size_t I = 0, N = Args.size(); I < N; ++I)
OS << Args[I]->getValueAsString("Name") << " A" << I << ", ";
for (size_t I = 0, N = Args.size(); I < N; ++I) {
const auto *Arg = Args[I];
bool AsRef = Arg->getValueAsBit("AsRef");
auto Name = Arg->getValueAsString("Name");

OS << (AsRef ? "const " : " ") << Name << " " << (AsRef ? "&" : "") << "A"
<< I << ", ";
}
OS << "const SourceInfo &I) {\n";

std::function<void(size_t, const Twine &)> Rec;
Expand Down Expand Up @@ -343,8 +367,14 @@ void ClangOpcodesEmitter::EmitEval(raw_ostream &OS, StringRef N,
auto Args = R->getValueAsListOfDefs("Args");

OS << "bool EvalEmitter::emit" << ID << "(";
for (size_t I = 0, N = Args.size(); I < N; ++I)
OS << Args[I]->getValueAsString("Name") << " A" << I << ", ";
for (size_t I = 0, N = Args.size(); I < N; ++I) {
const auto *Arg = Args[I];
bool AsRef = Arg->getValueAsBit("AsRef");
auto Name = Arg->getValueAsString("Name");

OS << (AsRef ? "const " : " ") << Name << " "
<< (AsRef ? "&" : "") << "A" << I << ", ";
}
OS << "const SourceInfo &L) {\n";
OS << " if (!isActive()) return true;\n";
OS << " CurrentSource = L;\n";
Expand Down