[BOLT] Fix comparison function for Linux ORC entries #79921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ORC entry comparison function to cover a case with multiple terminator entries matching at the same IP.
aaupov
reviewed
Jan 30, 2024
| @@ -95,7 +95,7 @@ class LinuxKernelRewriter final : public MetadataRewriter { | |||
| return 1; | |||
| if (IP > Other.IP) | |||
| return 0; | |||
| return ORC == NullORC; | |||
| return ORC == NullORC && Other.ORC != NullORC; | |||
There was a problem hiding this comment.
Is it important to have an ordering for NullORC entries? Should we order NullORC entries by some sequential id?
There was a problem hiding this comment.
No need, they are all the same.
aaupov
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ORC entry comparison function to cover a case with multiple terminator entries matching at the same IP.