[libc++] [NFC] Documentation: Add _LIBCPP_PUSH_MACROS and _LIBCPP_POP_MACROS

[H-G-Hristov]

I got tripped twice after: 7b46225 Let's at least mention these in the Contributing.rst doc.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

I got tripped twice after: 7b46225 Let's at least mention these in the Contributing.rst doc.

---

Full diff: https://github.com/llvm/llvm-project/pull/79963.diff

1 Files Affected:

• (modified) libcxx/docs/Contributing.rst (+1)

diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst
index 3ff8c15a969b0..596d86ef22449 100644
--- a/libcxx/docs/Contributing.rst
+++ b/libcxx/docs/Contributing.rst
@@ -162,6 +162,7 @@ sure you don't forget anything:
 
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
+- If needed, did you add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` to the relevant headers?
 
 The review process
 ==================

[H-G-Hristov]

@ldionne I don't think that these macros are documented and it can be confusing when the CI starts poping up cryptic error messages. I think they should be documented. I only realized what was the issue after seeing this commit: 7b46225

[ldionne]

This makes sense to me. It's really unfortunate that we even need this, but oh well.