Skip to content

[Clang] Fix typo in __fprintf_chk Prototype #80012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[Clang] Fix typo in __fprintf_chk Prototype #80012

merged 1 commit into from
Jan 30, 2024

Conversation

jsji
Copy link
Member

@jsji jsji commented Jan 30, 2024

An extra int was copied.

@jsji jsji requested a review from philnik777 January 30, 2024 14:49
@jsji jsji self-assigned this Jan 30, 2024
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jan 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 30, 2024

@llvm/pr-subscribers-clang

Author: Jinsong Ji (jsji)

Changes

An extra int was copied.


Full diff: https://github.com/llvm/llvm-project/pull/80012.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/Builtins.td (+1-1)
diff --git a/clang/include/clang/Basic/Builtins.td b/clang/include/clang/Basic/Builtins.td
index 1af01fe0d700..31a2bdeb2d3e 100644
--- a/clang/include/clang/Basic/Builtins.td
+++ b/clang/include/clang/Basic/Builtins.td
@@ -1065,7 +1065,7 @@ def FPrintfChk : Builtin {
 def PrintfChk : Builtin {
   let Spellings = ["__builtin___printf_chk"];
   let Attributes = [FunctionWithBuiltinPrefix, PrintfFormat<1>];
-  let Prototype = "int(int, int, char const* restrict, ...)";
+  let Prototype = "int(int, char const* restrict, ...)";
 }
 
 def VFPrintfChk : Builtin {

@jsji jsji requested review from AaronBallman and jyu2-git January 30, 2024 14:55
Copy link
Contributor

@jyu2-git jyu2-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before restruct:
It is defined as
clang/Basic/Builtins.def:731:BUILTIN(__builtin___printf_chk, "iicC*R.", "Fp:1:")

LGTM.
Thanks for fix.

@jsji jsji merged commit 235f1e7 into llvm:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants