Skip to content

[openmp] On Windows, fix standalone cmake build #80174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2024
+8 −0
Merged

[openmp] On Windows, fix standalone cmake build #80174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d67ce4
[openmp] On Windows, fix standalone cmake build
aganea Jan 31, 2024
196f133
[openmp][cmake] Add 'append' cmake command if it's not already there
aganea Jan 31, 2024
4654c3d
Remove extra spaces
aganea Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions openmp/cmake/HandleOpenMPOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ if (NOT COMMAND append_if)
endfunction()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then here we can just call append

endif()

if (NOT COMMAND append)
function(append value)
foreach(variable ${ARGN})
set(${variable} "${${variable}} ${value}" PARENT_SCOPE)
endforeach(variable)
endfunction()
endif()

# MSVC and clang-cl in compatibility mode map -Wall to -Weverything.
# TODO: LLVM adds /W4 instead, check if that works for the OpenMP runtimes.
if (NOT MSVC)
Expand Down