[PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types. #80784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. |
2 similar comments
|
Ping. |
|
Ping. |
|
Ping on this review once again :) |
redstar
reviewed
Apr 1, 2024
diggerlin
reviewed
Apr 10, 2024
diggerlin
reviewed
Apr 10, 2024
amy-kwan
force-pushed
the
amy-kwan/vector-shuff-stov
branch
from
6df51c4 to
efd6964
Compare
maryammo
reviewed
Apr 24, 2024
|
Ping. :-) |
diggerlin
reviewed
May 6, 2024
amy-kwan
force-pushed
the
amy-kwan/vector-shuff-stov
branch
from
efd6964 to
0e0d5cf
Compare
amy-kwan
force-pushed
the
amy-kwan/vector-shuff-stov
branch
from
0e0d5cf to
0f01dfb
Compare
|
Ping. |
diggerlin
reviewed
Oct 11, 2024
diggerlin
reviewed
Oct 11, 2024
diggerlin
reviewed
Oct 15, 2024
diggerlin
reviewed
Oct 15, 2024
redstar
reviewed
Oct 29, 2024
…r of differing types. This patch fixes the combines for vector_shuffles when either or both of its left and right hand side inputs are scalar_to_vector nodes. Previously, when both left and right side inputs are scalar_to_vector nodes, the current combine could not handle this situation, as the shuffle mask was updated incorrectly. To temporarily solve this solution, this combine was simply disabled and not performed. Now, not only does this patch aim to resolve the previous issue of the incorrect shuffle mask adjustments respectively, but it also updates any test cases that are affected by this change. Patch migrated from https://reviews.llvm.org/D130487.
…on code into a static function.
amy-kwan
force-pushed
the
amy-kwan/vector-shuff-stov
branch
from
0f01dfb to
fc931e4
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
diggerlin
approved these changes
Nov 6, 2024
|
thanks for addressing all the comments |
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…r of differing types. (llvm#80784) This patch fixes the combines for vector_shuffles when either or both of its left and right hand side inputs are scalar_to_vector nodes. Previously, when both left and right side inputs are scalar_to_vector nodes, the current combine could not handle this situation, as the shuffle mask was updated incorrectly. To temporarily solve this solution, this combine was simply disabled and not performed. Now, not only does this patch aim to resolve the previous issue of the incorrect shuffle mask adjustments respectively, but it also updates any test cases that are affected by this change. Patch migrated from https://reviews.llvm.org/D130487.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the combines for vector_shuffles when either or both of its left
and right hand side inputs are scalar_to_vector nodes.
Previously, when both left and right side inputs are scalar_to_vector nodes, the
current combine could not handle this situation, as the shuffle mask was updated
incorrectly. To temporarily solve this solution, this combine was simply disabled
and not performed.
Now, not only does this patch aim to resolve the previous issue of the incorrect
shuffle mask adjustments respectively, but it also updates any test cases that are
affected by this change.
Patch migrated from https://reviews.llvm.org/D130487.