Skip to content

[llvm][cmake] Performing expensive checks requires enabling assert. #80821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2024
Merged

[llvm][cmake] Performing expensive checks requires enabling assert. #80821

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04fbb56
[llvm][unittests] add NDEBUG for some unittests
huaatian Feb 6, 2024
f1049d9
[llvm][unittests] add NDEBUG for some unittests update 1
huaatian Feb 6, 2024
7eb7b6a
Merge branch 'main' into add_NDEBUG_to_some_unittests
huaatian Feb 6, 2024
d7fb1bc
Merge branch 'main' into add_NDEBUG_to_some_unittests
huaatian Feb 18, 2024
f3d32f1
[llvm][cmake] Performing expensive checks requires enabling assert.
huaatian Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ if( LLVM_ENABLE_ASSERTIONS )
endif()

if(LLVM_ENABLE_EXPENSIVE_CHECKS)
# When LLVM_ENABLE_EXPENSIVE_CHECKS is ON, LLVM will intercept errors
# using assert(). An explicit check is performed here.
if (NOT LLVM_ENABLE_ASSERTIONS)
message(FATAL_ERROR "LLVM_ENABLE_EXPENSIVE_CHECKS requires LLVM_ENABLE_ASSERTIONS \"ON\".")
endif()
add_compile_definitions(EXPENSIVE_CHECKS)

# In some libstdc++ versions, std::min_element is not constexpr when
Expand Down