[mlir][EmitC] Add builders for call_opaque op

[simon-camp]

This allows to omit the default valued attributes and therefore write more compact code.

[llvmbot]

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-emitc

Author: Simon Camphausen (simon-camp)

Changes

Add builders for the call_opaque op that has default valued attributes at the end. These can then be omitted during op creation.

---

Full diff: https://github.com/llvm/llvm-project/pull/80879.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/EmitC/IR/EmitC.td (+21)

diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index 39cc360cef41d4..b264a582df5aad 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -122,6 +122,27 @@ def EmitC_CallOpaqueOp : EmitC_Op<"call_opaque", []> {
     Variadic<AnyType>:$operands
   );
   let results = (outs Variadic<AnyType>);
+  let builders = [
+    OpBuilder<(ins
+      "::mlir::TypeRange":$resultTypes,
+      "::llvm::StringRef":$callee,
+      "::mlir::ValueRange":$operands,
+      CArg<"::mlir::ArrayAttr", "{}">:$args,
+      CArg<"::mlir::ArrayAttr", "{}">:$template_args), [{
+        build($_builder, $_state, resultTypes, callee, args, template_args, operands);
+      }]
+    >,
+    OpBuilder<(ins
+      "::mlir::TypeRange":$resultTypes,
+      "::mlir::StringAttr":$callee,
+      "::mlir::ValueRange":$operands,
+      CArg<"::mlir::ArrayAttr", "{}">:$args,
+      CArg<"::mlir::ArrayAttr", "{}">:$template_args), [{
+        build($_builder, $_state, resultTypes, callee, args, template_args, operands);
+      }]
+    >
+  ];
+
   let assemblyFormat = [{
     $callee `(` $operands `)` attr-dict `:` functional-type($operands, results)
   }];

[AlexDenisov]

Thank you, I was about to suggest reordering optional op arguments (to move them to the end), but this is even better!

[simon-camp]

Thank you, I was about to suggest reordering optional op arguments (to move them to the end), but this is even better!

That's what I did first and then I realized it would break all downstream users 😄