Skip to content

Don't search for separate debug files for mach-o object files #81041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Don't search for separate debug files for mach-o object files #81041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
787d48c
Don't search for separate debug files for mach-o object files
jimingham Feb 7, 2024
b2e7c7e
Format futzing
jimingham Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,13 @@ SymbolVendorMacOSX::CreateInstance(const lldb::ModuleSP &module_sp,
FileSpec dsym_fspec(module_sp->GetSymbolFileFileSpec());

ObjectFileSP dsym_objfile_sp;
if (!dsym_fspec) {
// On Darwin, we store the debug information either in object files,
// using the debug map to tie them to the executable, or in a dSYM. We
// pass through this routine both for binaries and for .o files, but in the
// latter case there will never be an external debug file. So we shouldn't
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "external debug file" in this context mean dwo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think I get it. This is looking up a dSYM by UUID.
LGTM

// do all the stats needed to find it.
if (!dsym_fspec && module_sp->GetObjectFile()->CalculateType() !=
ObjectFile::eTypeObjectFile) {
// No symbol file was specified in the module, lets try and find one
// ourselves.
FileSpec file_spec = obj_file->GetFileSpec();
Expand Down