Skip to content

[Docs][DebugInfo][RemoveDIs] Revise debug info migration guide title #81480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jryans
Copy link
Member

@jryans jryans commented Feb 12, 2024

As @aeubanks mentioned, the debug info migration guide could use a better title for clarity. This revises the title to make the topic more obvious.

@jryans jryans requested review from jmorse and aeubanks February 12, 2024 13:43
@llvmbot
Copy link
Member

llvmbot commented Feb 12, 2024

@llvm/pr-subscribers-debuginfo

Author: J. Ryan Stinnett (jryans)

Changes

As @aeubanks mentioned, the debug info migration guide could use a better title for clarity. This revises the title to make the topic more obvious.


Full diff: https://github.com/llvm/llvm-project/pull/81480.diff

1 Files Affected:

  • (modified) llvm/docs/RemoveDIsDebugInfo.md (+1-1)
diff --git a/llvm/docs/RemoveDIsDebugInfo.md b/llvm/docs/RemoveDIsDebugInfo.md
index e871fed43a7cc..a0577678e20fc 100644
--- a/llvm/docs/RemoveDIsDebugInfo.md
+++ b/llvm/docs/RemoveDIsDebugInfo.md
@@ -1,4 +1,4 @@
-# What's all this then?
+# Debug info migration: From intrinsics to records
 
 We're planning on removing debug info intrinsics from LLVM, as they're slow, unwieldy and can confuse optimisation passes if they're not expecting them. Instead of having a sequence of instructions that looks like this:
 

Copy link
Member

@jmorse jmorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me squints -- apologies, I think I wrote that under the impression that the page title would be presented as "RemoveDIs" or something like that, and didn't check once it landed.

LGTM.

@jryans jryans merged commit a3dcc7a into llvm:main Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants