Skip to content

Revert "[lldb-dap] Add support for data breakpoint. (#81541)" #81812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -501,18 +501,6 @@ def get_local_variable_value(self, name, frameIndex=0, threadId=None):
return variable["value"]
return None

def get_local_variable_child(self, name, child_name, frameIndex=0, threadId=None):
local = self.get_local_variable(name, frameIndex, threadId)
if local["variablesReference"] == 0:
return None
children = self.request_variables(local["variablesReference"])["body"][
"variables"
]
for child in children:
if child["name"] == child_name:
return child
return None

def replay_packets(self, replay_file_path):
f = open(replay_file_path, "r")
mode = "invalid"
Expand Down Expand Up @@ -907,41 +895,6 @@ def request_setFunctionBreakpoints(self, names, condition=None, hitCondition=Non
}
return self.send_recv(command_dict)

def request_dataBreakpointInfo(
self, variablesReference, name, frameIndex=0, threadId=None
):
stackFrame = self.get_stackFrame(frameIndex=frameIndex, threadId=threadId)
if stackFrame is None:
return []
args_dict = {
"variablesReference": variablesReference,
"name": name,
"frameId": stackFrame["id"],
}
command_dict = {
"command": "dataBreakpointInfo",
"type": "request",
"arguments": args_dict,
}
return self.send_recv(command_dict)

def request_setDataBreakpoint(self, dataBreakpoints):
"""dataBreakpoints is a list of dictionary with following fields:
{
dataId: (address in hex)/(size in bytes)
accessType: read/write/readWrite
[condition]: string
[hitCondition]: string
}
"""
args_dict = {"breakpoints": dataBreakpoints}
command_dict = {
"command": "setDataBreakpoints",
"type": "request",
"arguments": args_dict,
}
return self.send_recv(command_dict)

def request_compileUnits(self, moduleId):
args_dict = {"moduleId": moduleId}
command_dict = {
Expand Down
3 changes: 0 additions & 3 deletions lldb/test/API/tools/lldb-dap/databreakpoint/Makefile

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions lldb/test/API/tools/lldb-dap/databreakpoint/main.cpp

This file was deleted.

1 change: 0 additions & 1 deletion lldb/tools/lldb-dap/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ add_lldb_tool(lldb-dap
RunInTerminal.cpp
SourceBreakpoint.cpp
DAP.cpp
Watchpoint.cpp

LINK_LIBS
liblldb
Expand Down
2 changes: 0 additions & 2 deletions lldb/tools/lldb-dap/DAPForward.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ struct BreakpointBase;
struct ExceptionBreakpoint;
struct FunctionBreakpoint;
struct SourceBreakpoint;
struct Watchpoint;
} // namespace lldb_dap

namespace lldb {
Expand All @@ -40,7 +39,6 @@ class SBStringList;
class SBTarget;
class SBThread;
class SBValue;
class SBWatchpoint;
} // namespace lldb

#endif
48 changes: 0 additions & 48 deletions lldb/tools/lldb-dap/Watchpoint.cpp

This file was deleted.

34 changes: 0 additions & 34 deletions lldb/tools/lldb-dap/Watchpoint.h

This file was deleted.

Loading