[llvm-dlltool] Use -N for input native def option to avoid conflict with GNU dlltool --no-delete option. #81847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstorsjo
reviewed
Feb 15, 2024
| @@ -32,7 +32,10 @@ ARMAP2-NEXT: __imp_aux_func in test.dll | |||
| ARMAP2-NEXT: __imp_func in test.dll | |||
| ARMAP2-NEXT: func in test.dll | |||
|
|
|||
| RUN: not llvm-dlltool -m arm64 -d test.def -n test2.def -l test2.lib 2>&1 | FileCheck --check-prefix=ERR %s | |||
| RUN: llvm-dlltool -m arm64ec -d test.def -N test2.def -l test3.lib | |||
There was a problem hiding this comment.
What does this line test, isn't this the exact same test as what's above on line 19?
There was a problem hiding this comment.
It was meant to test the long form, but I failed to commit the final version. I pushed a fixup.
dpaoliello
approved these changes
Feb 15, 2024
…ith GNU dlltool --no-delete option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @mstorsjo in #81624. Also fixes the long form alias.