Skip to content

[lldb] Use PyBytes and PyByteArray in Python Data Objects unittest #82098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2024
Merged

[lldb] Use PyBytes and PyByteArray in Python Data Objects unittest #82098

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0abbba
[lldb] Use Py_REFCNT instead of accessing ob_refcnt directly
JDevlieghere Feb 17, 2024
bf1e1d4
[lldb] Use PyBytes and PyByteArray in Python Data Objects unittest
JDevlieghere Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,24 @@ class PythonDataObjectsTest : public PythonTestSuite {

TEST_F(PythonDataObjectsTest, TestOwnedReferences) {
// After creating a new object, the refcount should be >= 1
PyObject *obj = PyLong_FromLong(3);
Py_ssize_t original_refcnt = obj->ob_refcnt;
PyObject *obj = PyBytes_FromString("foo");
Py_ssize_t original_refcnt = Py_REFCNT(obj);
EXPECT_LE(1, original_refcnt);

// If we take an owned reference, the refcount should be the same
PythonObject owned_long(PyRefType::Owned, obj);
EXPECT_EQ(original_refcnt, owned_long.get()->ob_refcnt);
PythonObject owned(PyRefType::Owned, obj);
Py_ssize_t owned_refcnt = Py_REFCNT(owned.get());
EXPECT_EQ(original_refcnt, owned_refcnt);

// Take another reference and verify that the refcount increases by 1
PythonObject strong_ref(owned_long);
EXPECT_EQ(original_refcnt + 1, strong_ref.get()->ob_refcnt);
PythonObject strong_ref(owned);
Py_ssize_t strong_refcnt = Py_REFCNT(strong_ref.get());
EXPECT_EQ(original_refcnt + 1, strong_refcnt);

// If we reset the first one, the refcount should be the original value.
owned_long.Reset();
EXPECT_EQ(original_refcnt, strong_ref.get()->ob_refcnt);
owned.Reset();
strong_refcnt = Py_REFCNT(strong_ref.get());
EXPECT_EQ(original_refcnt, strong_refcnt);
}

TEST_F(PythonDataObjectsTest, TestResetting) {
Expand All @@ -82,12 +85,15 @@ TEST_F(PythonDataObjectsTest, TestResetting) {
}

TEST_F(PythonDataObjectsTest, TestBorrowedReferences) {
PythonInteger long_value(PyRefType::Owned, PyLong_FromLong(3));
Py_ssize_t original_refcnt = long_value.get()->ob_refcnt;
PythonByteArray byte_value(PyRefType::Owned,
PyByteArray_FromStringAndSize("foo", 3));
Py_ssize_t original_refcnt = Py_REFCNT(byte_value.get());
EXPECT_LE(1, original_refcnt);

PythonInteger borrowed_long(PyRefType::Borrowed, long_value.get());
EXPECT_EQ(original_refcnt + 1, borrowed_long.get()->ob_refcnt);
PythonByteArray borrowed_byte(PyRefType::Borrowed, byte_value.get());
Py_ssize_t borrowed_refcnt = Py_REFCNT(borrowed_byte.get());

EXPECT_EQ(original_refcnt + 1, borrowed_refcnt);
}

TEST_F(PythonDataObjectsTest, TestGlobalNameResolutionNoDot) {
Expand Down