[BOLT][NFC] Simplify YAMLProfileWriter::convert #82129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
ayermolo
approved these changes
Feb 29, 2024
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfc-simplify-yamlprofilewriterconvert
to
main
aaupov
changed the base branch from
main
to
users/aaupov/spr/main.boltnfc-simplify-yamlprofilewriterconvert
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfc-simplify-yamlprofilewriterconvert
to
main
aaupov
deleted the
users/aaupov/spr/boltnfc-simplify-yamlprofilewriterconvert
branch
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
Use `getAnnotationWithDefault` instead of testing if the annotation is set. If the default value is used, and `CSI.Count` is set to zero, the target is discarded by a check below. Test Plan: NFC Reviewers: maksfb, dcci, rafaelauler, ayermolo Reviewed By: ayermolo Pull Request: llvm#82129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
getAnnotationWithDefaultinstead of testing if the annotation isset. If the default value is used, and
CSI.Countis set to zero, thetarget is discarded by a check below.
Test Plan: NFC