Skip to content

[Github] Add ability to filter jobs in job counting script #82136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

boomanaiden154
Copy link
Contributor

This patch adds a new flag pair, --filter-gha-runners, and --no-filter-gha-runners, that filters out all non-Github hosted runners so that we can actual counts of the Github runners, where we are actually limited.

This patch adds a new flag pair, --filter-gha-runners, and
--no-filter-gha-runners, that filters out all non-Github hosted runners
so that we can actual counts of the Github runners, where we are
actually limited.
@boomanaiden154
Copy link
Contributor Author

This also depends on PyGithub/PyGithub#2902 (and probably them tagging a new release as well). Not sure exactly when that will happen.

@tstellar
Copy link
Collaborator

This also depends on PyGithub/PyGithub#2902 (and probably them tagging a new release as well). Not sure exactly when that will happen.

Will the script still work with older versions of pygithub if you don't use this new option?

@boomanaiden154
Copy link
Contributor Author

Will the script still work with older versions of pygithub if you don't use this new option?

Good point. I was originally planning on just landing this after the version gets released, but just making sure that it works with the flag disabled (and making that the default) and landing it now probably makes a lot more sense. I've updated the patch to not enable the new flag by default, and add error handling for old versions indicating what the issue is on top of adding a TODO to remove the error handling once we're able to migrate to a PyGithub version with the patches that we need.

@boomanaiden154 boomanaiden154 merged commit 66d8377 into llvm:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants