Skip to content

[RemoveDIs] Account for DPVAssigns in isIdenticalToWhenDefined #82257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[RemoveDIs] Account for DPVAssigns in isIdenticalToWhenDefined #82257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions llvm/include/llvm/IR/DebugProgramInstruction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,16 +271,15 @@ class DPValue : public ilist_node<DPValue>, private DebugValueUser {
std::optional<uint64_t> getFragmentSizeInBits() const;

bool isEquivalentTo(const DPValue &Other) {
return std::tie(Type, DebugValues, Variable, Expression, DbgLoc) ==
std::tie(Other.Type, Other.DebugValues, Other.Variable,
Other.Expression, Other.DbgLoc);
return DbgLoc == Other.DbgLoc && isIdenticalToWhenDefined(Other);
}
// Matches the definition of the Instruction version, equivalent to above but
// without checking DbgLoc.
bool isIdenticalToWhenDefined(const DPValue &Other) {
return std::tie(Type, DebugValues, Variable, Expression) ==
return std::tie(Type, DebugValues, Variable, Expression,
AddressExpression) ==
std::tie(Other.Type, Other.DebugValues, Other.Variable,
Other.Expression);
Other.Expression, Other.AddressExpression);
}

/// @name DbgAssign Methods
Expand Down