Revert "[llvm] Fix assertion error where we didn't check fixed point types." #82285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types. (…" This reverts commit 1807e02.
|
@llvm/pr-subscribers-debuginfo Author: Vladimir Vereschaka (vvereschaka) ChangesThese changes break the The problem wasn't fixed for few days, Reverts llvm/llvm-project#80757 Full diff: https://github.com/llvm/llvm-project/pull/82285.diff 2 Files Affected:
diff --git a/llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp b/llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
index f00ff1565c665f..eb2d992c7e75e7 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
@@ -224,15 +224,12 @@ bool DebugHandlerBase::isUnsignedDIType(const DIType *Ty) {
Encoding == dwarf::DW_ATE_float || Encoding == dwarf::DW_ATE_UTF ||
Encoding == dwarf::DW_ATE_boolean ||
Encoding == dwarf::DW_ATE_complex_float ||
- Encoding == dwarf::DW_ATE_signed_fixed ||
- Encoding == dwarf::DW_ATE_unsigned_fixed ||
(Ty->getTag() == dwarf::DW_TAG_unspecified_type &&
Ty->getName() == "decltype(nullptr)")) &&
"Unsupported encoding");
return Encoding == dwarf::DW_ATE_unsigned ||
Encoding == dwarf::DW_ATE_unsigned_char ||
Encoding == dwarf::DW_ATE_UTF || Encoding == dwarf::DW_ATE_boolean ||
- Encoding == llvm::dwarf::DW_ATE_unsigned_fixed ||
Ty->getTag() == dwarf::DW_TAG_unspecified_type;
}
diff --git a/llvm/test/DebugInfo/fixed-point.ll b/llvm/test/DebugInfo/fixed-point.ll
deleted file mode 100644
index 0de984484c0e60..00000000000000
--- a/llvm/test/DebugInfo/fixed-point.ll
+++ /dev/null
@@ -1,31 +0,0 @@
-;; This fixes https://github.com/llvm/llvm-project/issues/81555
-; RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump - | FileCheck %s
-; RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump - -verify | FileCheck %s --check-prefix=VERIFY
-
-; VERIFY-NOT: error:
-
-; CHECK: {{.*}}: DW_TAG_base_type
-; CHECK-NEXT: DW_AT_name ("var")
-; CHECK-NEXT: DW_AT_encoding (DW_ATE_signed_fixed)
-define void @func() !dbg !26 {
-entry:
- %classifier = alloca i32, align 4
- tail call void @llvm.dbg.value(metadata i32 32768, metadata !37, metadata !DIExpression()), !dbg !39
- store i32 32768, ptr %classifier, align 4, !dbg !39
- ret void
-}
-
-declare void @llvm.dbg.value(metadata, metadata, metadata)
-
-!llvm.dbg.cu = !{!0}
-!llvm.module.flags = !{!19}
-
-!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, emissionKind: FullDebug)
-!1 = !DIFile(filename: "a", directory: "")
-!6 = !DIBasicType(name: "var", size: 32, encoding: DW_ATE_signed_fixed)
-!19 = !{i32 2, !"Debug Info Version", i32 3}
-!3 = !DISubroutineType(types: null)
-!26 = distinct !DISubprogram(unit: !0, type: !3)
-!37 = !DILocalVariable(name: "intercept", arg: 2, scope: !26, file: !1, line: 7, type: !6)
-!39 = !DILocation(line: 0, scope: !26)
-
|
|
@PiJoules FYI |
|
|
|
the |
PiJoules
added a commit
to PiJoules/llvm-project
that referenced
this pull request
Feb 20, 2024
… types." (llvm#82285) This reverts commit d9f9775. The test was missing a `REQUIRES: object-emission`.
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Apr 24, 2024
llvm#82412) … types." (llvm#82285) This reverts commit d9f9775. The test was missing a `REQUIRES: object-emission`. (cherry picked from commit 0b2b91e)
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Apr 24, 2024
llvm#82412) … types." (llvm#82285) This reverts commit d9f9775. The test was missing a `REQUIRES: object-emission`. (cherry picked from commit 0b2b91e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes break the
LLVM::fixed-point.lltest some targets what fails the builds for those targets(more details #80757 (comment))
The problem wasn't fixed for few days,
Reverts #80757