Skip to content

[BOLT][DWARF][NFC] Expose DebugStrOffsetsWriter::clear #82548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ayermolo
Copy link
Contributor

@ayermolo ayermolo commented Feb 21, 2024

Refactored cod that clears data-structures in DebugStrOffsetsWriter into clear() function and made initialize() public. This is for #81062.

Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but please retitle to something like "[BOLT][DWARF][NFC] Expose DebugStrOffsetsWriter::clear" and address typos in the commit message.

@ayermolo ayermolo changed the title [BOLT][DWARF] Refactor DebugStrOffsetsWriter [BOLT][DWARF][NFC] Expose DebugStrOffsetsWriter::clear Feb 22, 2024
Refactored clearning data structures in DebugStrOffsetsWriter into clear()
function and made initialize() public. This is for
llvm#81062.
@ayermolo ayermolo merged commit 004c197 into llvm:main Feb 22, 2024
@ayermolo ayermolo deleted the refactorClear branch February 22, 2024 00:48
qiaojbao pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Mar 21, 2024
…784e3612a

Local branch amd-gfx acd784e Merged main:162fa4dd25d631d0ab7816ec6081bcaff951a23c into amd-gfx:7ab2a1875722
Remote branch main 004c197 [BOLT][DWARF][NFC] Expose DebugStrOffsetsWriter::clear (llvm#82548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants