[Driver] Allow -fbasic-block-address-map for AArch64 ELF

[dhoekwater]

Emitting the basic block address map with
-fbasic-block-sections=labels is allowed for AArch64 ELF since
7eaf94f. Allow doing so with
-fbasic-block-address-map.

[llvmbot]

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Daniel Hoekwater (dhoekwater)

Changes

Emitting the basic block address map with
-fbasic-block-sections=labels is allowed for AArch64 ELF since
7eaf94f. Allow doing so with
-fbasic-block-address-map.

---

Full diff: https://github.com/llvm/llvm-project/pull/82662.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChains/Clang.cpp (+1-1)

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 7c0409f0c3097a..22c9b5e76710db 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -5958,7 +5958,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
 
   if (Arg *A = Args.getLastArg(options::OPT_fbasic_block_address_map,
                                options::OPT_fno_basic_block_address_map)) {
-    if (Triple.isX86() && Triple.isOSBinFormatELF()) {
+    if ((Triple.isX86() || Triple.isAArch64()) && Triple.isOSBinFormatELF()) {
       if (A->getOption().matches(options::OPT_fbasic_block_address_map))
         A->render(Args, CmdArgs);
     } else {

[dhoekwater]

None of the failing checks seem to be due to my change, so I'm going to keep rebasing onto HEAD until something sticks. If there's a better way than force pushing to my fork, I don't know of it.

[mysterymath]

Hi, we've narrowed down a LLDB test failure on Fuchsia's AArch64 builders to this change:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8754880571862677073/overview

There were only three likely culprits in the blamelist (this change, #83201, #83214, and), but reverting each only produces a successful run if this change is reverted. Can you think of why this change would break that test?

[mysterymath]

I'm terribly sorry, this was the wrong change from the blamelist. NAR.