Users/tsitdikov #82757
Merged
Users/tsitdikov #82757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix TestArmSME library and build rule.
tsitdikov
requested review from
banach-space,
dcaballe and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-sme Author: None (tsitdikov) ChangesFix Test ARM SME library and build rule. Full diff: https://github.com/llvm/llvm-project/pull/82757.diff 2 Files Affected:
diff --git a/mlir/test/lib/Dialect/ArmSME/CMakeLists.txt b/mlir/test/lib/Dialect/ArmSME/CMakeLists.txt
index de4971ff7eb3d1..e942c7b8ac058c 100644
--- a/mlir/test/lib/Dialect/ArmSME/CMakeLists.txt
+++ b/mlir/test/lib/Dialect/ArmSME/CMakeLists.txt
@@ -8,6 +8,8 @@ add_mlir_library(MLIRArmSMETestPasses
MLIRArithToArmSME
MLIRArmSMEToLLVM
MLIRArmSMEToSCF
+ MLIRArmSMETransforms
+ MLIRArmSVETransforms
MLIRIR
MLIRPass
MLIRTransforms
diff --git a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
index 497256573dfc5a..68d9b23fd5643e 100644
--- a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -914,6 +914,8 @@ cc_library(
"//mlir:ArithToArmSME",
"//mlir:ArmSMEToLLVM",
"//mlir:ArmSMEToSCF",
+ "//mlir:ArmSMETransforms",
+ "//mlir:ArmSVETransforms",
"//mlir:IR",
"//mlir:Pass",
"//mlir:Transforms",
|
akuegel
approved these changes
Feb 23, 2024
|
Please write correct commit message / title (@akuegel : this is part of the approval / review). |
Yes, sorry, I only checked the code change and missed this. I saw it after it was committed, and already told the author. But I guess this cannot be changed afterwards. |
|
No big deal, if you noticed it's good, I just pointed it for next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Test ARM SME library and build rule.