Skip to content

[RFC][clang][Support] Extract type parsing function. [NFCI] #82797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[RFC][clang][Support] Extract type parsing function. [NFCI] #82797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions clang/include/clang/Support/BuiltinsUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
//===--- BuiltinsUtils.h - clang Builtins Utils -*- C++ -*-----------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef CLANG_SUPPORT_BUILTINSUTILS_H
#define CLANG_SUPPORT_BUILTINSUTILS_H

#include "llvm/ADT/StringRef.h"
#include <string>
namespace llvm {
class SMLoc;
}
namespace clang {

/// Parse builtins prototypes according to the rules in
/// clang/include/clang/Basic/Builtins.def
void ParseBuiltinType(llvm::StringRef T, llvm::StringRef Substitution,
std::string &Type, llvm::SMLoc *Loc);

} // namespace clang
#endif // CLANG_SUPPORT_BUILTINSUTILS_H
1 change: 1 addition & 0 deletions clang/lib/Support/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ set(LLVM_LINK_COMPONENTS

set(clangSupport_sources
RISCVVIntrinsicUtils.cpp
ClangBuiltinsUtils.cpp
)

add_clang_library(clangSupport ${clangSupport_sources})
Expand Down
81 changes: 81 additions & 0 deletions clang/lib/Support/ClangBuiltinsUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
#include "clang/Support/BuiltinsUtils.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/SMLoc.h"
#include "llvm/TableGen/Error.h"

void clang::ParseBuiltinType(llvm::StringRef T, llvm::StringRef Substitution,
std::string &Type, llvm::SMLoc *Loc) {
assert(Loc);
T = T.trim();
if (T.consume_back("*")) {
ParseBuiltinType(T, Substitution, Type, Loc);
Type += "*";
} else if (T.consume_back("const")) {
ParseBuiltinType(T, Substitution, Type, Loc);
Type += "C";
} else if (T.consume_back("volatile")) {
ParseBuiltinType(T, Substitution, Type, Loc);
Type += "D";
} else if (T.consume_back("restrict")) {
ParseBuiltinType(T, Substitution, Type, Loc);
Type += "R";
} else if (T.consume_back("&")) {
ParseBuiltinType(T, Substitution, Type, Loc);
Type += "&";
} else if (T.consume_front("long")) {
Type += "L";
ParseBuiltinType(T, Substitution, Type, Loc);
} else if (T.consume_front("unsigned")) {
Type += "U";
ParseBuiltinType(T, Substitution, Type, Loc);
} else if (T.consume_front("_Complex")) {
Type += "X";
ParseBuiltinType(T, Substitution, Type, Loc);
} else if (T.consume_front("_Constant")) {
Type += "I";
ParseBuiltinType(T, Substitution, Type, Loc);
} else if (T.consume_front("T")) {
if (Substitution.empty())
llvm::PrintFatalError(*Loc, "Not a template");
ParseBuiltinType(Substitution, Substitution, Type, Loc);
} else {
auto ReturnTypeVal = llvm::StringSwitch<std::string>(T)
.Case("__builtin_va_list_ref", "A")
.Case("__builtin_va_list", "a")
.Case("__float128", "LLd")
.Case("__fp16", "h")
.Case("__int128_t", "LLLi")
.Case("_Float16", "x")
.Case("bool", "b")
.Case("char", "c")
.Case("constant_CFString", "F")
.Case("double", "d")
.Case("FILE", "P")
.Case("float", "f")
.Case("id", "G")
.Case("int", "i")
.Case("int32_t", "Zi")
.Case("int64_t", "Wi")
.Case("jmp_buf", "J")
.Case("msint32_t", "Ni")
.Case("msuint32_t", "UNi")
.Case("objc_super", "M")
.Case("pid_t", "p")
.Case("ptrdiff_t", "Y")
.Case("SEL", "H")
.Case("short", "s")
.Case("sigjmp_buf", "SJ")
.Case("size_t", "z")
.Case("ucontext_t", "K")
.Case("uint32_t", "UZi")
.Case("uint64_t", "UWi")
.Case("void", "v")
.Case("wchar_t", "w")
.Case("...", ".")
.Default("error");
if (ReturnTypeVal == "error")
llvm::PrintFatalError(*Loc, "Unknown Type: " + T);

Type += ReturnTypeVal;
}
}
74 changes: 2 additions & 72 deletions clang/utils/TableGen/ClangBuiltinsEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
//===----------------------------------------------------------------------===//

#include "TableGenBackends.h"
#include "clang/Support/BuiltinsUtils.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/TableGen/Error.h"
#include "llvm/TableGen/Record.h"
#include "llvm/TableGen/TableGenBackend.h"

using namespace llvm;

namespace {
Expand Down Expand Up @@ -53,77 +53,7 @@ class PrototypeParser {
}

void ParseType(StringRef T) {
T = T.trim();
if (T.consume_back("*")) {
ParseType(T);
Type += "*";
} else if (T.consume_back("const")) {
ParseType(T);
Type += "C";
} else if (T.consume_back("volatile")) {
ParseType(T);
Type += "D";
} else if (T.consume_back("restrict")) {
ParseType(T);
Type += "R";
} else if (T.consume_back("&")) {
ParseType(T);
Type += "&";
} else if (T.consume_front("long")) {
Type += "L";
ParseType(T);
} else if (T.consume_front("unsigned")) {
Type += "U";
ParseType(T);
} else if (T.consume_front("_Complex")) {
Type += "X";
ParseType(T);
} else if (T.consume_front("_Constant")) {
Type += "I";
ParseType(T);
} else if (T.consume_front("T")) {
if (Substitution.empty())
PrintFatalError(Loc, "Not a template");
ParseType(Substitution);
} else {
auto ReturnTypeVal = StringSwitch<std::string>(T)
.Case("__builtin_va_list_ref", "A")
.Case("__builtin_va_list", "a")
.Case("__float128", "LLd")
.Case("__fp16", "h")
.Case("__int128_t", "LLLi")
.Case("_Float16", "x")
.Case("bool", "b")
.Case("char", "c")
.Case("constant_CFString", "F")
.Case("double", "d")
.Case("FILE", "P")
.Case("float", "f")
.Case("id", "G")
.Case("int", "i")
.Case("int32_t", "Zi")
.Case("int64_t", "Wi")
.Case("jmp_buf", "J")
.Case("msint32_t", "Ni")
.Case("msuint32_t", "UNi")
.Case("objc_super", "M")
.Case("pid_t", "p")
.Case("ptrdiff_t", "Y")
.Case("SEL", "H")
.Case("short", "s")
.Case("sigjmp_buf", "SJ")
.Case("size_t", "z")
.Case("ucontext_t", "K")
.Case("uint32_t", "UZi")
.Case("uint64_t", "UWi")
.Case("void", "v")
.Case("wchar_t", "w")
.Case("...", ".")
.Default("error");
if (ReturnTypeVal == "error")
PrintFatalError(Loc, "Unknown Type: " + T);
Type += ReturnTypeVal;
}
clang::ParseBuiltinType(T, Substitution, Type, &Loc);
}

public:
Expand Down