[BOLT] Fix runtime/instrument-wrong-target.s test #82858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was failing when only X86 was specified for LLVM_TARGETS_TO_BUILD. Changed so that it will now report unsupporeted. For "X86;AArch64" it still passes. For "X86" reports UNSUPPORTED: BOLT :: runtime/instrument-wrong-target.s (1 of 1)
ayermolo
requested review from
aaupov,
maksfb,
rafaelauler and
dcci
as code owners
dcci
approved these changes
Feb 26, 2024
dcci
reviewed
Feb 26, 2024
| @@ -1,7 +1,8 @@ | |||
| # Test that BOLT errs when trying to instrument a binary with a different | |||
| # architecture than the one BOLT is built for. | |||
|
|
|||
| # REQUIRES: x86_64-linux,bolt-runtime,target=x86_64{{.*}} | |||
| # REQUIRES: x86_64-linux,bolt-runtime | |||
| # REQUIRES: target-x86_64 && aarch64-registered-target | |||
There was a problem hiding this comment.
I've never seen this syntax with &&. Is it a new addition? Anyway, if you tested it and it works, LG.
There was a problem hiding this comment.
Not sure if it's a new syntax. I have seen it in some other tests.
|
If the test is X86-specific, we should move it under |
It's not? It needs both x86 and aarch64 to work. |
The host has to be x86. But we can move it afterwords since your fix is targeting a different issue. |
maksfb
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was failing when only X86 was specified for LLVM_TARGETS_TO_BUILD. Changed so that it will now report unsupporeted.
For "X86;AArch64" it still passes.
For "X86" reports UNSUPPORTED: BOLT :: runtime/instrument-wrong-target.s (1 of 1)