Skip to content

Fix TestI64ElementsAttr printer #82931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mfrancio
Copy link
Contributor

This enables to correctly roundtrip the attribute to text or bytecode.

This enables to correctly roundtrip the attribute to text or bytecode.
@llvmbot llvmbot added the mlir label Feb 25, 2024
@mfrancio mfrancio requested a review from joker-eph February 25, 2024 19:19
@llvmbot
Copy link
Member

llvmbot commented Feb 25, 2024

@llvm/pr-subscribers-mlir

Author: Matteo Franciolini (mfrancio)

Changes

This enables to correctly roundtrip the attribute to text or bytecode.


Full diff: https://github.com/llvm/llvm-project/pull/82931.diff

1 Files Affected:

  • (modified) mlir/test/lib/Dialect/Test/TestAttributes.cpp (+1-1)
diff --git a/mlir/test/lib/Dialect/Test/TestAttributes.cpp b/mlir/test/lib/Dialect/Test/TestAttributes.cpp
index 8819f6cbe94e2c..d41d495c38e553 100644
--- a/mlir/test/lib/Dialect/Test/TestAttributes.cpp
+++ b/mlir/test/lib/Dialect/Test/TestAttributes.cpp
@@ -82,7 +82,7 @@ Attribute TestI64ElementsAttr::parse(AsmParser &parser, Type type) {
 void TestI64ElementsAttr::print(AsmPrinter &printer) const {
   printer << "<[";
   llvm::interleaveComma(getElements(), printer);
-  printer << "] : " << getType() << ">";
+  printer << "]>";
 }
 
 LogicalResult

@mfrancio mfrancio changed the title Fix TestI64ElementsAttr parser Fix TestI64ElementsAttr printer Feb 25, 2024
@mfrancio mfrancio merged commit bc6b5be into llvm:main Feb 26, 2024
@mfrancio mfrancio deleted the dev/mfrancio/fixTestI64ElementsAttrPrinter branch February 26, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants