Skip to content

Fix a few links to passes documentation #83221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mlevesquedion
Copy link
Contributor

@mlevesquedion mlevesquedion commented Feb 28, 2024

I double checked the links by building the website:

./mlir-www-helper.sh --install-docs ../llvm-project website
cd website && hugo serve

@llvmbot llvmbot added the mlir label Feb 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 28, 2024

@llvm/pr-subscribers-mlir

Author: mlevesquedion (mlevesquedion)

Changes

I double checked the links by building the website:

$ mlir-www-helper.sh --install-docs ../llvm-project website
$ cd website && hugo serve

Full diff: https://github.com/llvm/llvm-project/pull/83221.diff

2 Files Affected:

  • (modified) mlir/docs/PassManagement.md (+1-2)
  • (modified) mlir/docs/PatternRewriter.md (+1-1)
diff --git a/mlir/docs/PassManagement.md b/mlir/docs/PassManagement.md
index ff86bbfef7b0bf..c9d705f0506a3e 100644
--- a/mlir/docs/PassManagement.md
+++ b/mlir/docs/PassManagement.md
@@ -56,8 +56,7 @@ By default, an operation pass is `op-agnostic`, meaning that it operates on the
 operation type of the pass manager that it is added to. This means a pass may operate
 on many different types of operations. Agnostic passes should be written such that
 they do not make assumptions on the operation they run on. Examples of this type of pass are
-[Canonicalization](Pass.md/-canonicalize-canonicalize-operations)
-[Common Sub-Expression Elimination](Passes.md/#-cse-eliminate-common-sub-expressions).
+[Canonicalization](Passes.md/#-canonicalize) and [Common Sub-Expression Elimination](Passes.md/#-cse).
 
 To create an agnostic operation pass, a derived class must adhere to the following:
 
diff --git a/mlir/docs/PatternRewriter.md b/mlir/docs/PatternRewriter.md
index 011cd14175634b..0ba76199874cc3 100644
--- a/mlir/docs/PatternRewriter.md
+++ b/mlir/docs/PatternRewriter.md
@@ -366,7 +366,7 @@ Note: This driver listens for IR changes via the callbacks provided by
 rewriter and do not bypass the rewriter API by modifying ops directly.
 
 Note: This driver is the one used by the [canonicalization](Canonicalization.md)
-[pass](Passes.md/#-canonicalize-canonicalize-operations) in MLIR.
+[pass](Passes.md/#-canonicalize) in MLIR.
 
 ### Debugging
 

@joker-eph joker-eph merged commit 267beb1 into llvm:main Feb 28, 2024
@joker-eph
Copy link
Collaborator

Thanks!

@mlevesquedion mlevesquedion deleted the fix-passes-links branch February 28, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants