[docs][TypeProf]Update instrumentation file format document #83309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingmingl-llvm
requested review from
modiking,
snehasish,
teresajohnson and
david-xl
david-xl
reviewed
Feb 28, 2024
david-xl
reviewed
Feb 28, 2024
david-xl
approved these changes
Feb 28, 2024
|
thanks for the review! On a second look I found this PR doesn't update ASCII art and header for indexed profiles. I will send out a separate PR to make indexed profile ASCII art and header more general and high-level -> pointing users to look at source code to know the exact fields, and document the high-level summary that offsets are used to indicate the position of sections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the profile format change