Don't do casting of atomic FP loads/stores in FE. #83446
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| // RUN: %clang_cc1 -triple s390x-linux-gnu -O1 -emit-llvm %s -o - | FileCheck %s | ||
| // | ||
| // Test that floating point atomic stores and loads do not get casted to/from | ||
| // integer. | ||
|
|
||
| #include <stdatomic.h> | ||
|
|
||
| _Atomic float Af; | ||
| _Atomic double Ad; | ||
| _Atomic long double Ald; | ||
|
|
||
| //// Atomic stores of floating point values. | ||
| void fun0(float Arg) { | ||
| // CHECK-LABEL: @fun0 | ||
| // CHECK: store atomic float %Arg, ptr @Af seq_cst, align 4 | ||
| Af = Arg; | ||
| } | ||
|
|
||
| void fun1(double Arg) { | ||
| // CHECK-LABEL: @fun1 | ||
| // CHECK: store atomic double %Arg, ptr @Ad seq_cst, align 8 | ||
| Ad = Arg; | ||
| } | ||
|
|
||
| void fun2(long double Arg) { | ||
| // CHECK-LABEL: @fun2 | ||
| // CHECK: store atomic fp128 %Arg, ptr @Ald seq_cst, align 16 | ||
| Ald = Arg; | ||
| } | ||
|
|
||
| void fun3(_Atomic float *Dst, float Arg) { | ||
| // CHECK-LABEL: @fun | ||
| // CHECK: store atomic float %Arg, ptr %Dst seq_cst, align 4 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| void fun4(_Atomic double *Dst, double Arg) { | ||
| // CHECK-LABEL: @fun4 | ||
| // CHECK: store atomic double %Arg, ptr %Dst seq_cst, align 8 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| void fun5(_Atomic long double *Dst, long double Arg) { | ||
| // CHECK-LABEL: @fun5 | ||
| // CHECK: store atomic fp128 %Arg, ptr %Dst seq_cst, align 16 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| //// Atomic loads of floating point values. | ||
| float fun6() { | ||
| // CHECK-LABEL: @fun6 | ||
| // CHECK: %atomic-load = load atomic float, ptr @Af seq_cst, align 4 | ||
| return Af; | ||
| } | ||
|
|
||
| float fun7() { | ||
| // CHECK-LABEL: @fun7 | ||
| // CHECK: %atomic-load = load atomic double, ptr @Ad seq_cst, align 8 | ||
| return Ad; | ||
| } | ||
|
|
||
| float fun8() { | ||
| // CHECK-LABEL: @fun8 | ||
| // CHECK: %atomic-load = load atomic fp128, ptr @Ald seq_cst, align 16 | ||
| return Ald; | ||
| } | ||
|
|
||
| float fun9(_Atomic float *Src) { | ||
| // CHECK-LABEL: @fun9 | ||
| // CHECK: %atomic-load = load atomic float, ptr %Src seq_cst, align 4 | ||
| return *Src; | ||
| } | ||
|
|
||
| double fun10(_Atomic double *Src) { | ||
| // CHECK-LABEL: @fun10 | ||
| // CHECK: %atomic-load = load atomic double, ptr %Src seq_cst, align 8 | ||
| return *Src; | ||
| } | ||
|
|
||
| long double fun11(_Atomic long double *Src) { | ||
| // CHECK-LABEL: @fun11 | ||
| // CHECK: %atomic-load = load atomic fp128, ptr %Src seq_cst, align 16 | ||
| return *Src; | ||
| } | ||
|
There was a problem hiding this comment. test the volatile is preserved too? |
||
|
|
||
| //// Same, but with 'volatile' as well: | ||
|
|
||
| _Atomic volatile float Af_vol; | ||
| _Atomic volatile double Ad_vol; | ||
| _Atomic volatile long double Ald_vol; | ||
|
|
||
| //// Atomic volatile stores of floating point values. | ||
| void fun0_vol(float Arg) { | ||
| // CHECK-LABEL: @fun0_vol | ||
| // CHECK: store atomic volatile float %Arg, ptr @Af_vol seq_cst, align 4 | ||
| Af_vol = Arg; | ||
| } | ||
|
|
||
| void fun1_vol(double Arg) { | ||
| // CHECK-LABEL: @fun1_vol | ||
| // CHECK: store atomic volatile double %Arg, ptr @Ad_vol seq_cst, align 8 | ||
| Ad_vol = Arg; | ||
| } | ||
|
|
||
| void fun2_vol(long double Arg) { | ||
| // CHECK-LABEL: @fun2_vol | ||
| // CHECK: store atomic volatile fp128 %Arg, ptr @Ald_vol seq_cst, align 16 | ||
| Ald_vol = Arg; | ||
| } | ||
|
|
||
| void fun3_vol(_Atomic volatile float *Dst, float Arg) { | ||
| // CHECK-LABEL: @fun3_vol | ||
| // CHECK: store atomic volatile float %Arg, ptr %Dst seq_cst, align 4 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| void fun4_vol(_Atomic volatile double *Dst, double Arg) { | ||
| // CHECK-LABEL: @fun4_vol | ||
| // CHECK: store atomic volatile double %Arg, ptr %Dst seq_cst, align 8 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| void fun5_vol(_Atomic volatile long double *Dst, long double Arg) { | ||
| // CHECK-LABEL: @fun5_vol | ||
| // CHECK: store atomic volatile fp128 %Arg, ptr %Dst seq_cst, align 16 | ||
| *Dst = Arg; | ||
| } | ||
|
|
||
| //// Atomic volatile loads of floating point values. | ||
| float fun6_vol() { | ||
| // CHECK-LABEL: @fun6_vol | ||
| // CHECK: %atomic-load = load atomic volatile float, ptr @Af_vol seq_cst, align 4 | ||
| return Af_vol; | ||
| } | ||
|
|
||
| float fun7_vol() { | ||
| // CHECK-LABEL: @fun7_vol | ||
| // CHECK: %atomic-load = load atomic volatile double, ptr @Ad_vol seq_cst, align 8 | ||
| return Ad_vol; | ||
| } | ||
|
|
||
| float fun8_vol() { | ||
| // CHECK-LABEL: @fun8_vol | ||
| // CHECK: %atomic-load = load atomic volatile fp128, ptr @Ald_vol seq_cst, align 16 | ||
| return Ald_vol; | ||
| } | ||
|
|
||
| float fun9_vol(_Atomic volatile float *Src) { | ||
| // CHECK-LABEL: @fun9_vol | ||
| // CHECK: %atomic-load = load atomic volatile float, ptr %Src seq_cst, align 4 | ||
| return *Src; | ||
| } | ||
|
|
||
| double fun10_vol(_Atomic volatile double *Src) { | ||
| // CHECK-LABEL: @fun10_vol | ||
| // CHECK: %atomic-load = load atomic volatile double, ptr %Src seq_cst, align 8 | ||
| return *Src; | ||
| } | ||
|
|
||
| long double fun11_vol(_Atomic volatile long double *Src) { | ||
| // CHECK-LABEL: @fun11_vol | ||
| // CHECK: %atomic-load = load atomic volatile fp128, ptr %Src seq_cst, align 16 | ||
| return *Src; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,6 +145,5 @@ void force_global_uses(void) { | |
| (void)glob_int; | ||
| // CHECK: load atomic i32, ptr @[[GLOB_INT]] seq_cst | ||
| (void)glob_flt; | ||
| // CHECK: load atomic float, ptr @[[GLOB_FLT]] seq_cst | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,15 +19,13 @@ void testFloat(_Atomic(float) *fp) { | |
| _Atomic(float) x = 2.0f; | ||
|
|
||
| // CHECK-NEXT: [[T0:%.*]] = load ptr, ptr [[FP]] | ||
| // CHECK-NEXT: [[T2:%.*]] = load atomic float, ptr [[T0]] seq_cst, align 4 | ||
| // CHECK-NEXT: store float [[T2]], ptr [[F]] | ||
| float f = *fp; | ||
|
|
||
| // CHECK-NEXT: [[T0:%.*]] = load float, ptr [[F]], align 4 | ||
| // CHECK-NEXT: [[T1:%.*]] = load ptr, ptr [[FP]], align 4 | ||
| // CHECK-NEXT: store atomic float [[T0]], ptr [[T1]] seq_cst, align 4 | ||
| *fp = f; | ||
|
|
||
| // CHECK-NEXT: ret void | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be casting pointers either. I think this should pass through all types directly to atomicrmw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As AtomicExpandPass doesn't do any casting of AtomicCmpXchg - at least currently - I think the other users of ConvertIntToValueOrAtomic() (which emit AtomicCmpXchg) need the current behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llvm-project/llvm/lib/CodeGen/AtomicExpandPass.cpp
Line 256 in d1538c1
It's wild how much junk clang ended up with to avoid writing proper backend support. It's fine to just do the FP in this patch, but I think all of this needs to be ripped out
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, AtomicExpandPass is actually casting pointers to int, but not with the target hook to control it...
I guess I could start with FP per this patch for now...