Skip to content

[libc++] Remove leftover .fail.cpp matcher in Lit test format #83583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Mar 1, 2024

This should have been removed in 8dcb8ea, which removed support for .fail.cpp tests in the libc++ test suite.

This should have been removed in 8dcb8ea, which removed support
for .fail.cpp tests in the libc++ test suite.
@ldionne ldionne requested a review from a team as a code owner March 1, 2024 15:29
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 1, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 1, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

This should have been removed in 8dcb8ea, which removed support for .fail.cpp tests in the libc++ test suite.


Full diff: https://github.com/llvm/llvm-project/pull/83583.diff

1 Files Affected:

  • (modified) libcxx/utils/libcxx/test/format.py (-1)
diff --git a/libcxx/utils/libcxx/test/format.py b/libcxx/utils/libcxx/test/format.py
index 229da224994f43..7e5281c0b74064 100644
--- a/libcxx/utils/libcxx/test/format.py
+++ b/libcxx/utils/libcxx/test/format.py
@@ -265,7 +265,6 @@ def getTestsForPath(self, testSuite, pathInSuite, litConfig, localConfig):
             "[.]sh[.][^.]+$",
             "[.]gen[.][^.]+$",
             "[.]verify[.]cpp$",
-            "[.]fail[.]cpp$",
         ]
 
         sourcePath = testSuite.getSourcePath(pathInSuite)

Copy link
Member

@mordante mordante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldionne ldionne merged commit d052148 into llvm:main Mar 4, 2024
@ldionne ldionne deleted the review/remove-fail-cpp branch March 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants